Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
	tarantool-patches@freelists.org,
	Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
Subject: [PATCH 0/3] *** [#3619] socket.recvfrom crops UDP packets ***
Date: Fri, 24 Aug 2018 05:47:36 +0300	[thread overview]
Message-ID: <cover.1535076888.git.alexander.turenko@tarantool.org> (raw)

Hi!

Vladimir, please review the patchset.

Yaroslav, please confirm that the new behaviour is one you want.

The changes in short:

* evaluate buffer size for a UDP socket in recv / recvfrom when it was
  not passed;
* discard a datagram in recv / recvfrom when it is larger then the input
  buffer, when the size was passed;
* prevent defererence of a pointer to non-initialized data in case of
  recvfrom was called for a TCP socket.

WBR, Alexander Turenko.

branch: Totktonada/gh-3619-socket-recvfrom-detect-a-cropped-packet
travis-ci: https://travis-ci.org/tarantool/tarantool/builds/419931085
issue: https://github.com/tarantool/tarantool/issues/3619

Alexander Turenko (3):
  socket: evaluate buffer size in recv / recvfrom
  socket: don't truncate a datagram in recv/recvfrom
  socket: prevent recvfrom from returning garbage

 src/lua/socket.c         |  25 ++
 src/lua/socket.lua       |  84 +++++-
 test/app/socket.result   | 540 ++++++++++++++++++++++++++++++++++++++-
 test/app/socket.test.lua | 198 ++++++++++++++
 4 files changed, 842 insertions(+), 5 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-08-24  2:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24  2:47 Alexander Turenko [this message]
2018-08-24  2:47 ` [PATCH 1/3] socket: evaluate buffer size in recv / recvfrom Alexander Turenko
2018-08-24 14:07   ` Vladimir Davydov
2018-08-24 15:25   ` Vladimir Davydov
2018-08-27  0:08     ` Alexander Turenko
2018-08-27  9:20       ` Vladimir Davydov
2018-08-27  9:26         ` Alexander Turenko
2018-08-24  2:47 ` [PATCH 2/3] socket: don't truncate a datagram in recv/recvfrom Alexander Turenko
2018-08-24 15:24   ` Vladimir Davydov
2018-08-24  2:47 ` [PATCH 3/3] socket: prevent recvfrom from returning garbage Alexander Turenko
2018-08-24 13:07   ` Vladimir Davydov
2018-08-24 13:44     ` Alexander Turenko
2018-08-24 13:55       ` Vladimir Davydov
2018-08-24 17:11   ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1535076888.git.alexander.turenko@tarantool.org \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --cc=yaroslav.dynnikov@tarantool.org \
    --subject='Re: [PATCH 0/3] *** [#3619] socket.recvfrom crops UDP packets ***' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox