From: Kirill Yukhin <kyukhin@tarantool.org> To: korablev@tarantool.org Cc: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org> Subject: [tarantool-patches] [PATCH 0/2] sql: update inexes after table rename Date: Mon, 20 Aug 2018 19:49:43 +0300 [thread overview] Message-ID: <cover.1534783275.git.kyukhin@tarantool.org> (raw) First patch in the patchset fixes indexes update, absense of which caused gh-3613 to fail. After that, another issue was uncovered. It seems that during comparing of index defs, opts.sql field was ignored, which in turn leads to ifnorance of updated indexes from xlog. Second patch takes ops.sql into account while comparing. Issue: https://github.com/tarantool/tarantool/issues/3613 Branch: https://github.com/tarantool/tarantool/commits/kyukhin/gh-3613-update-idx-afer-alter Kirill Yukhin (2): sql: after table rename properly update indexes sql: take sql field in index_opts_cmp src/box/index_def.h | 8 ++++ src/box/sql.c | 57 +++++++++++++++++++++------- src/box/sql/build.c | 7 ++-- src/box/sql/tarantoolInt.h | 23 ++++++++++- src/box/sql/vdbe.c | 26 ++++++++++++- test/sql/gh-3613-idx-alter-update-2.result | 28 ++++++++++++++ test/sql/gh-3613-idx-alter-update-2.test.lua | 16 ++++++++ test/sql/gh-3613-idx-alter-update.result | 38 +++++++++++++++++++ test/sql/gh-3613-idx-alter-update.test.lua | 21 ++++++++++ 9 files changed, 203 insertions(+), 21 deletions(-) create mode 100644 test/sql/gh-3613-idx-alter-update-2.result create mode 100644 test/sql/gh-3613-idx-alter-update-2.test.lua create mode 100644 test/sql/gh-3613-idx-alter-update.result create mode 100644 test/sql/gh-3613-idx-alter-update.test.lua -- 2.16.2
next reply other threads:[~2018-08-20 16:49 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-20 16:49 Kirill Yukhin [this message] 2018-08-20 16:49 ` [tarantool-patches] [PATCH 1/2] sql: after table rename properly update indexes Kirill Yukhin 2018-08-21 10:26 ` [tarantool-patches] " n.pettik 2018-08-21 12:20 ` Kirill Yukhin 2018-08-21 20:38 ` n.pettik 2018-08-22 6:39 ` Kirill Yukhin 2018-08-20 16:49 ` [tarantool-patches] [PATCH 2/2] sql: take sql field in index_opts_cmp Kirill Yukhin 2018-08-21 10:26 ` [tarantool-patches] " n.pettik 2018-08-21 12:30 ` Kirill Yukhin 2018-08-21 20:41 ` n.pettik 2018-08-22 6:47 ` [tarantool-patches] Re: [PATCH 0/2] sql: update inexes after table rename Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1534783275.git.kyukhin@tarantool.org \ --to=kyukhin@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH 0/2] sql: update inexes after table rename' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox