From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [RFC PATCH 00/23] vinyl: eliminate read on REPLACE/DELETE Date: Sun, 8 Jul 2018 19:48:31 +0300 [thread overview] Message-ID: <cover.1531065648.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <1c13a7ce54e2ba625965212fb538725cd974699b.1531065648.git.vdavydov.dev@gmail.com> This patch set optimizes REPLACE and DELETE operations in vinyl in presence of secondary indexes: now they don't need to read the primary key in order to delete the overwritten/deleted tuple from secondary indexes, instead this job is handed over to primary index compaction task, while read iterator filters out overwritten tuples that haven't been purged yet. The patch set still has a few serious problems (deferred DELETEs generated by compaction task may be lost on restart; generation of deferred DELETEs may cause OOM in tx thread) and needs some efforts to be put in it, but it passes all functional tests should be suitable for testing and the first round of review. Most patches will stay the same anyways. https://github.com/tarantool/tarantool/issues/2129 https://github.com/tarantool/tarantool/commits/dv/gh-2129-vy-eliminate-read-on-replace-delete Vladimir Davydov (23): vinyl: do not turn REPLACE into INSERT when processing DML request vinyl: always get full tuple from pk after reading from secondary index vinyl: use vy_mem_iterator for point lookup vinyl: make point lookup always return the latest tuple version vinyl: fold vy_replace_one and vy_replace_impl vinyl: fold vy_delete_impl vinyl: refactor unique check vinyl: check key uniqueness before modifying tx write set vinyl: remove env argument of vy_check_is_unique_{primary,secondary} vinyl: store full tuples in secondary index cache xrow: allow to store flags in DML requests vinyl: do not pass region explicitly to write iterator functions vinyl: fix potential use-after-free in vy_read_view_merge test: unit/vy_write_iterator: minor refactoring vinyl: teach write iterator to return overwritten tuples vinyl: allow to skip certain statements on read vinyl: do not free pending tasks on shutdown vinyl: store pointer to scheduler in struct vy_task vinyl: rename some members of vy_scheduler and vy_task struct vinyl: use cbus for communication between scheduler and worker threads vinyl: zap vy_scheduler::is_worker_pool_running vinyl: rename vy_task::status to is_failed vinyl: eliminate read on REPLACE/DELETE src/box/iproto_constants.c | 4 +- src/box/iproto_constants.h | 3 +- src/box/vinyl.c | 792 +++++++++++++++++++------------------ src/box/vy_mem.c | 19 +- src/box/vy_point_lookup.c | 87 ++-- src/box/vy_point_lookup.h | 9 +- src/box/vy_read_iterator.c | 61 ++- src/box/vy_read_iterator.h | 24 ++ src/box/vy_run.c | 7 +- src/box/vy_scheduler.c | 563 ++++++++++++++++++-------- src/box/vy_scheduler.h | 41 +- src/box/vy_stmt.c | 4 + src/box/vy_stmt.h | 44 +++ src/box/vy_tx.c | 26 ++ src/box/vy_write_iterator.c | 173 ++++++-- src/box/vy_write_iterator.h | 27 +- src/box/xrow.c | 8 + src/box/xrow.h | 2 + test/unit/vy_iterators_helper.c | 5 + test/unit/vy_iterators_helper.h | 12 +- test/unit/vy_point_lookup.c | 4 +- test/unit/vy_write_iterator.c | 319 ++++++++++++--- test/unit/vy_write_iterator.result | 23 +- test/vinyl/info.result | 5 + test/vinyl/info.test.lua | 3 + test/vinyl/layout.result | 166 +++++--- test/vinyl/tx_gap_lock.result | 16 +- test/vinyl/tx_gap_lock.test.lua | 10 +- test/vinyl/write_iterator.result | 11 +- test/vinyl/write_iterator.test.lua | 5 +- 30 files changed, 1615 insertions(+), 858 deletions(-) -- 2.11.0
next prev parent reply other threads:[~2018-07-08 16:48 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-08 16:48 [RFC PATCH 02/23] vinyl: always get full tuple from pk after reading from secondary index Vladimir Davydov 2018-07-08 16:48 ` Vladimir Davydov [this message] 2018-07-08 16:48 ` [RFC PATCH 01/23] vinyl: do not turn REPLACE into INSERT when processing DML request Vladimir Davydov 2018-07-10 12:15 ` Konstantin Osipov 2018-07-10 12:19 ` Vladimir Davydov 2018-07-10 18:39 ` Konstantin Osipov 2018-07-11 7:57 ` Vladimir Davydov 2018-07-11 10:25 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 03/23] vinyl: use vy_mem_iterator for point lookup Vladimir Davydov 2018-07-17 10:14 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 04/23] vinyl: make point lookup always return the latest tuple version Vladimir Davydov 2018-07-10 16:19 ` Konstantin Osipov 2018-07-10 16:43 ` Vladimir Davydov 2018-07-11 16:33 ` Vladimir Davydov 2018-07-31 19:17 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 05/23] vinyl: fold vy_replace_one and vy_replace_impl Vladimir Davydov 2018-07-31 20:28 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 06/23] vinyl: fold vy_delete_impl Vladimir Davydov 2018-07-31 20:28 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 07/23] vinyl: refactor unique check Vladimir Davydov 2018-07-31 20:28 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 08/23] vinyl: check key uniqueness before modifying tx write set Vladimir Davydov 2018-07-31 20:34 ` Konstantin Osipov 2018-08-01 10:42 ` Vladimir Davydov 2018-08-09 20:26 ` Konstantin Osipov 2018-08-10 8:26 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 09/23] vinyl: remove env argument of vy_check_is_unique_{primary,secondary} Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 10/23] vinyl: store full tuples in secondary index cache Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 11/23] xrow: allow to store flags in DML requests Vladimir Davydov 2018-07-31 20:36 ` Konstantin Osipov 2018-08-01 14:10 ` Vladimir Davydov 2018-08-17 13:34 ` Vladimir Davydov 2018-08-17 13:34 ` [PATCH 1/2] xrow: allow to store tuple metadata in request Vladimir Davydov 2018-08-17 13:34 ` [PATCH 2/2] vinyl: introduce statement flags Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 12/23] vinyl: do not pass region explicitly to write iterator functions Vladimir Davydov 2018-07-17 10:16 ` Vladimir Davydov 2018-07-31 20:38 ` Konstantin Osipov 2018-08-01 14:14 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 13/23] vinyl: fix potential use-after-free in vy_read_view_merge Vladimir Davydov 2018-07-17 10:16 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 14/23] test: unit/vy_write_iterator: minor refactoring Vladimir Davydov 2018-07-17 10:17 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 15/23] vinyl: teach write iterator to return overwritten tuples Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 16/23] vinyl: allow to skip certain statements on read Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 17/23] vinyl: do not free pending tasks on shutdown Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 18/23] vinyl: store pointer to scheduler in struct vy_task Vladimir Davydov 2018-07-31 20:39 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 19/23] vinyl: rename some members of vy_scheduler and vy_task struct Vladimir Davydov 2018-07-31 20:40 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 20/23] vinyl: use cbus for communication between scheduler and worker threads Vladimir Davydov 2018-07-31 20:43 ` Konstantin Osipov 2018-08-01 14:26 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 21/23] vinyl: zap vy_scheduler::is_worker_pool_running Vladimir Davydov 2018-07-31 20:43 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 22/23] vinyl: rename vy_task::status to is_failed Vladimir Davydov 2018-07-31 20:44 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 23/23] vinyl: eliminate read on REPLACE/DELETE Vladimir Davydov 2018-07-13 10:53 ` Vladimir Davydov 2018-07-13 10:53 ` [PATCH 1/3] stailq: add stailq_insert function Vladimir Davydov 2018-07-15 7:02 ` Konstantin Osipov 2018-07-15 13:17 ` Vladimir Davydov 2018-07-15 18:40 ` Konstantin Osipov 2018-07-17 10:18 ` Vladimir Davydov 2018-07-13 10:53 ` [PATCH 2/3] vinyl: link all indexes of the same space Vladimir Davydov 2018-07-13 10:53 ` [PATCH 3/3] vinyl: generate deferred DELETEs on tx commit Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1531065648.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [RFC PATCH 00/23] vinyl: eliminate read on REPLACE/DELETE' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox