From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: [tarantool-patches] [PATCH v1 0/4] sql: remove Triggers to server Date: Thu, 31 May 2018 14:22:49 +0300 [thread overview] Message-ID: <cover.1527765756.git.kshcherbatov@tarantool.org> (raw) Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3273-no-sql-triggers Issue: https://github.com/tarantool/tarantool/issues/3273 As we are going to call parser on box.cfg() to recreate triggers from SQL, we should initialize Schema as it used in sqlite3BeginTrigger. Inroduced box_space_id_by_name to get object id by name from custom space. Fixed bug in tarantoolSqlite3RenameTrigger: sql request have had invalid length in MsgPack after ALTER TABLE NAME. Introduced sql_triggers field in space structure. Changed parser logic to do not insert builded triggers, just only to do parsing. All triggers insertions and deletions are operated via on_replace_dd_trigger now. Kirill Shcherbatov (4): box: move db->pShchema init to sql_init sql: fix sql len in tarantoolSqlite3RenameTrigger box: introduce box_space_id_by_name sql: move Triggers to server src/box/alter.cc | 57 +++++++++++ src/box/box.cc | 10 +- src/box/box.h | 14 +++ src/box/space.h | 2 + src/box/sql.c | 60 ++++------- src/box/sql.h | 62 ++++++++++++ src/box/sql/build.c | 8 +- src/box/sql/insert.c | 6 +- src/box/sql/sqliteInt.h | 2 - src/box/sql/tokenize.c | 43 +++++++- src/box/sql/trigger.c | 258 ++++++++++++++++++++++++++++-------------------- src/box/sql/vdbe.c | 58 +++-------- src/box/sql/vdbe.h | 1 - src/box/sql/vdbeaux.c | 9 -- 14 files changed, 374 insertions(+), 216 deletions(-) -- 2.7.4
next reply other threads:[~2018-05-31 11:22 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-31 11:22 Kirill Shcherbatov [this message] 2018-05-31 11:22 ` [tarantool-patches] [PATCH v1 1/4] box: move db->pShchema init to sql_init Kirill Shcherbatov 2018-05-31 17:36 ` [tarantool-patches] " Vladislav Shpilevoy 2018-06-01 20:24 ` Kirill Shcherbatov 2018-05-31 11:22 ` [tarantool-patches] [PATCH v1 2/4] sql: fix sql len in tarantoolSqlite3RenameTrigger Kirill Shcherbatov 2018-05-31 11:22 ` [tarantool-patches] [PATCH v1 3/4] box: introduce box_space_id_by_name Kirill Shcherbatov 2018-05-31 17:36 ` [tarantool-patches] " Vladislav Shpilevoy 2018-06-01 20:24 ` Kirill Shcherbatov 2018-06-04 13:27 ` Vladislav Shpilevoy 2018-06-04 19:21 ` Kirill Shcherbatov 2018-06-05 13:31 ` Vladislav Shpilevoy 2018-05-31 11:22 ` [tarantool-patches] [PATCH v1 4/4] sql: move Triggers to server Kirill Shcherbatov 2018-05-31 17:36 ` [tarantool-patches] " Vladislav Shpilevoy 2018-06-01 20:24 ` Kirill Shcherbatov 2018-06-01 20:25 ` Kirill Shcherbatov 2018-06-04 13:27 ` Vladislav Shpilevoy 2018-06-04 19:21 ` Kirill Shcherbatov 2018-06-05 13:31 ` Vladislav Shpilevoy 2018-06-09 9:32 ` Kirill Shcherbatov 2018-06-01 18:51 ` Konstantin Osipov 2018-05-31 17:36 ` [tarantool-patches] Re: [PATCH v1 0/4] sql: remove " Vladislav Shpilevoy 2018-06-04 13:27 ` Vladislav Shpilevoy 2018-06-05 13:31 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1527765756.git.kshcherbatov@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [tarantool-patches] [PATCH v1 0/4] sql: remove Triggers to server' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox