From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH v2 0/2] Follow-up on async memtx index cleanup Date: Tue, 22 May 2018 20:25:29 +0300 [thread overview] Message-ID: <cover.1527009486.git.vdavydov.dev@gmail.com> (raw) Turned out that after commit 2a1482f33fa0 ("memtx: free tuples asynchronously when primary index is dropped"), we can't merge 1.10 to 2.0 without breaking tests, because one of the tests (namely sql-tap/gh-3083-ephemeral-unref-tuples) executes a lot of SQL SELECT statements without yielding. Those statements in turn create a lot of ephemeral spaces that consume all available memory since memtx garbage collection doesn't have a chance to clean up. To fix that, this patch set improves the garbage collection procedure: now it is invoked not only by a background fiber, but also on demand, i.e. when any of memtx functions fails to allocate memory. https://github.com/tarantool/tarantool/issues/3408 https://github.com/tarantool/tarantool/commits/memtx-run-gc-on-demand Changes in v2: - Patches 1-6 pushed with minor changes. Patches 7-8 => Patches 1-2. - Add gc task vtab to separate task destruction from gc callback. - Return gc task state in an argument. v1: https://www.freelists.org/post/tarantool-patches/PATCH-08-Followup-on-async-memtx-index-cleanup Vladimir Davydov (2): memtx: rework background garbage collection procedure memtx: run garbage collection on demand src/box/index.cc | 7 ++++++- src/box/memtx_engine.c | 54 +++++++++++++++++++++++++++++++++++++++++++------- src/box/memtx_engine.h | 17 +++++++++++++--- src/box/memtx_hash.c | 35 ++++++++++++++++++++++---------- src/box/memtx_hash.h | 1 + src/box/memtx_tree.c | 38 ++++++++++++++++++++++++----------- src/box/memtx_tree.h | 1 + 7 files changed, 119 insertions(+), 34 deletions(-) -- 2.11.0
next reply other threads:[~2018-05-22 17:25 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 17:25 Vladimir Davydov [this message] 2018-05-22 17:25 ` [PATCH v2 1/2] memtx: rework background garbage collection procedure Vladimir Davydov 2018-05-23 17:56 ` Konstantin Osipov 2018-05-24 6:13 ` Vladimir Davydov 2018-05-22 17:25 ` [PATCH v2 2/2] memtx: run garbage collection on demand Vladimir Davydov 2018-05-23 17:58 ` Konstantin Osipov 2018-05-24 6:15 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1527009486.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH v2 0/2] Follow-up on async memtx index cleanup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox