From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH 0/8] Follow-up on async memtx index cleanup Date: Tue, 22 May 2018 14:46:08 +0300 [thread overview] Message-ID: <cover.1526987033.git.vdavydov.dev@gmail.com> (raw) Turned out that after commit 2a1482f33fa0 ("memtx: free tuples asynchronously when primary index is dropped"), we can't merge 1.10 to 2.0 without breaking tests, because one of the tests (namely sql-tap/gh-3083-ephemeral-unref-tuples) executes a lot of SQL SELECT statements without yielding. Those statements in turn create a lot of ephemeral spaces that consume all available memory since memtx garbage collection doesn't have a chance to clean up. To fix that, this patch set improves the garbage collection procedure: now it is invoked not only by a background fiber, but also on demand, i.e. when any of memtx functions fails to allocate memory. https://github.com/tarantool/tarantool/issues/3408 https://github.com/tarantool/tarantool/commits/memtx-run-gc-on-demand Vladimir Davydov (8): memtx: init index extent allocator in engine constructor memtx: fold memtx_tuple.cc into memtx_engine.c memtx: pass engine to memory allocation functions memtx: move all global variables to engine memtx: destroy slab arena on engine shutdown memtx: embed light hash into memtx_hash_index memtx: rework background garbage collection procedure memtx: run garbage collection on demand src/box/CMakeLists.txt | 1 - src/box/alter.cc | 1 - src/box/index.cc | 7 +- src/box/lua/slab.c | 35 ++++--- src/box/lua/tuple.c | 1 - src/box/lua/xlog.c | 1 - src/box/memtx_bitset.c | 4 +- src/box/memtx_engine.c | 257 ++++++++++++++++++++++++++++++++++--------------- src/box/memtx_engine.h | 67 ++++++++++--- src/box/memtx_hash.c | 93 ++++++------------ src/box/memtx_hash.h | 35 ++++++- src/box/memtx_rtree.c | 4 +- src/box/memtx_space.c | 7 +- src/box/memtx_tree.c | 33 +++---- src/box/memtx_tree.h | 1 + src/box/memtx_tuple.cc | 193 ------------------------------------- src/box/memtx_tuple.h | 100 ------------------- src/box/tuple_format.c | 1 + src/box/tuple_format.h | 2 + 19 files changed, 349 insertions(+), 494 deletions(-) delete mode 100644 src/box/memtx_tuple.cc delete mode 100644 src/box/memtx_tuple.h -- 2.11.0
next reply other threads:[~2018-05-22 11:46 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 11:46 Vladimir Davydov [this message] 2018-05-22 11:46 ` [PATCH 1/8] memtx: init index extent allocator in engine constructor Vladimir Davydov 2018-05-22 13:43 ` Konstantin Osipov 2018-05-22 11:46 ` [PATCH 2/8] memtx: fold memtx_tuple.cc into memtx_engine.c Vladimir Davydov 2018-05-22 13:45 ` Konstantin Osipov 2018-05-22 11:46 ` [PATCH 3/8] memtx: pass engine to memory allocation functions Vladimir Davydov 2018-05-22 13:47 ` Konstantin Osipov 2018-05-22 14:39 ` Vladimir Davydov 2018-05-22 11:46 ` [PATCH 4/8] memtx: move all global variables to engine Vladimir Davydov 2018-05-22 13:48 ` Konstantin Osipov 2018-05-22 11:46 ` [PATCH 5/8] memtx: destroy slab arena on engine shutdown Vladimir Davydov 2018-05-22 13:50 ` Konstantin Osipov 2018-05-22 16:26 ` Vladimir Davydov 2018-05-22 11:46 ` [PATCH 6/8] memtx: embed light hash into memtx_hash_index Vladimir Davydov 2018-05-22 13:51 ` Konstantin Osipov 2018-05-22 11:46 ` [PATCH 7/8] memtx: rework background garbage collection procedure Vladimir Davydov 2018-05-22 13:56 ` Konstantin Osipov 2018-05-22 14:49 ` Vladimir Davydov 2018-05-22 16:42 ` Konstantin Osipov 2018-05-22 11:46 ` [PATCH 8/8] memtx: run garbage collection on demand Vladimir Davydov 2018-05-22 14:00 ` Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1526987033.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 0/8] Follow-up on async memtx index cleanup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox