Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>
To: georgy@tarantool.org, kostja@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH 0/3] replication: improve logging.
Date: Wed, 16 May 2018 14:32:24 +0300	[thread overview]
Message-ID: <cover.1526469555.git.k.belyavskiy@tarantool.org> (raw)

Ticket: https://github.com/tarantool/tarantool/issues/3365
Branch: https://github.com/tarantool/tarantool/compare/gh-3365-display-an-error-at-downstream-on-replica-failure-or-disconnect-v3

This is set of patches originally aiming to improve error logging.
First patch includes small refactoring (reuse a subset of applier
state machine for tracking replication quorum state).
Second patch is about do not remove relay on applier disconnect.
AR: Konstya, Gosha currently I'm not happy about relay_create part
there I use memset for all relay structure, resulting in possible
data/state loss. I'm thinking about to use memset only for new
relya and reset for others.
Third pathc improves logging (duplicate same error for master and
replica and store it in relay state).

Konstantin Belyavskiy (3):
  replication: use applier_state to check quorum
  replication: do not delete relay on applier disconnect
  replication: display downstream status at upstream

 src/box/lua/info.c                                 |  19 +++-
 src/box/relay.cc                                   |  78 ++++++++++----
 src/box/relay.h                                    |  30 ++++++
 src/box/replication.cc                             |  60 +++++------
 src/box/replication.h                              |  43 +++-----
 test/replication/show_error_on_disconnect.result   | 120 +++++++++++++++++++++
 test/replication/show_error_on_disconnect.test.lua |  38 +++++++
 7 files changed, 305 insertions(+), 83 deletions(-)
 create mode 100644 test/replication/show_error_on_disconnect.result
 create mode 100644 test/replication/show_error_on_disconnect.test.lua

-- 
2.14.3 (Apple Git-98)

             reply	other threads:[~2018-05-16 11:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 11:32 Konstantin Belyavskiy [this message]
2018-05-16 11:32 ` [tarantool-patches] [PATCH 1/3] replication: use applier_state to check quorum Konstantin Belyavskiy
2018-05-16 11:32 ` [tarantool-patches] [PATCH 2/3] replication: do not delete relay on applier disconnect Konstantin Belyavskiy
2018-05-16 11:32 ` [tarantool-patches] [PATCH 3/3] replication: display downstream status at upstream Konstantin Belyavskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1526469555.git.k.belyavskiy@tarantool.org \
    --to=k.belyavskiy@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 0/3] replication: improve logging.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox