Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/2] sql: SQL bindings refactoring
Date: Wed, 11 Apr 2018 22:35:03 +0300	[thread overview]
Message-ID: <cover.1523468339.git.korablev@tarantool.org> (raw)

Branch: https://github.com/tarantool/tarantool/tree/np/gh-3332-format-leak-fix
Issue: https://github.com/tarantool/tarantool/issues/3332

First patch introduces fix for leaked tuple formats: under certain
circumstances (described in commit message) some tuples from ephemeral
space may remain referenced after space's death and as a result, format
can't be destroyed.

Second patch consists of slight refactoring of cursor closing routine.

Nikita Pettik (2):
  sql: fix tuple format leak
  sql: refactor cursor closing routine

 src/box/sql.c                                   | 60 +++++++++++--------------
 src/box/sql/cursor.c                            | 46 ++++++++++---------
 src/box/sql/cursor.h                            |  6 ++-
 src/box/sql/tarantoolInt.h                      |  8 ++--
 src/box/sql/vdbe.c                              | 35 +++++----------
 src/box/sql/vdbeaux.c                           |  2 +-
 test/sql-tap/gh-3332-tuple-format-leak.test.lua | 31 +++++++++++++
 7 files changed, 101 insertions(+), 87 deletions(-)
 create mode 100755 test/sql-tap/gh-3332-tuple-format-leak.test.lua

-- 
2.15.1

             reply	other threads:[~2018-04-11 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 19:35 Nikita Pettik [this message]
2018-04-11 19:35 ` [tarantool-patches] [PATCH 1/2] sql: fix tuple format leak Nikita Pettik
2018-04-12 11:58   ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-13  8:39     ` n.pettik
2018-04-11 19:35 ` [tarantool-patches] [PATCH 2/2] sql: refactor cursor closing routine Nikita Pettik
2018-04-12 13:28   ` [tarantool-patches] " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1523468339.git.korablev@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [tarantool-patches] [PATCH 0/2] sql: SQL bindings refactoring' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox