From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org
Subject: [tarantool-patches] [PATCH 0/2] netbox: reuse _request() to do SQL execute()
Date: Thu, 5 Apr 2018 22:28:08 +0300 [thread overview]
Message-ID: <cover.1522956408.git.v.shpilevoy@tarantool.org> (raw)
Branch: http://github.com/tarantool/tarantool/tree/gh-3323-3322-sql-iproto-schema-change
Issue: https://github.com/tarantool/tarantool/issues/3323
Issue: https://github.com/tarantool/tarantool/issues/3322
_request() is a wrapper for perform_request, that detects schema
changes, and waits until it is reloaded. Lets use _request()
instead of direct perform_request() for execute(). The reason why
the _request() was not used earlier was my attempt to avoid
multiple return values in _request(), that leads to minor fixes
in non-execute methods like index.select or eval/call_16, which
return the _request() directly.
But diplicating schema reloading logic for execute() is worse.
Vladislav Shpilevoy (2):
netbox: forbid conn:timeout():execute(...)
netbox: reuse _request() to do SQL execute()
src/box/lua/net_box.lua | 77 +++++++++++++++++++++++------------------------
test/box/net.box.result | 5 +--
test/box/net.box.test.lua | 5 +--
test/sql/iproto.result | 45 ---------------------------
test/sql/iproto.test.lua | 15 ---------
5 files changed, 44 insertions(+), 103 deletions(-)
--
2.14.3 (Apple Git-98)
next reply other threads:[~2018-04-05 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 19:28 Vladislav Shpilevoy [this message]
2018-04-05 19:28 ` [tarantool-patches] [PATCH 1/2] netbox: forbid conn:timeout():execute(...) Vladislav Shpilevoy
2018-04-05 20:08 ` [tarantool-patches] " Konstantin Osipov
2018-04-05 19:28 ` [tarantool-patches] [PATCH 2/2] netbox: reuse _request() to do SQL execute() Vladislav Shpilevoy
2018-04-05 20:07 ` [tarantool-patches] " Konstantin Osipov
2018-04-05 23:30 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1522956408.git.v.shpilevoy@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 0/2] netbox: reuse _request() to do SQL execute()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox