Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/4] sql: refactor insertion and lua
Date: Tue,  3 Apr 2018 18:34:11 +0300	[thread overview]
Message-ID: <cover.1522769319.git.v.shpilevoy@tarantool.org> (raw)

Branch: http://github.com/tarantool/tarantool/tree/gh-2618-preliminary-patches
Issue: https://github.com/tarantool/tarantool/issues/2618

The patchset consists of patches preliminary to SQL IProto
"last updated tuple" introduction. It is possible, that its
implementation plan will be changed several times, but this
patchset looks useful even with no IProto "last updated tuple".

1) The patch does SQL INSERT/UPDATE refactoring by removal of 2
unused VDBE parameters, and by restyling of final insertion
opcodes generator: sqlite3CompleteInsertion.

2) The patch does refactoring of Lua SQL executor, that is
extremely overengineered now.

Vladislav Shpilevoy (4):
  sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace]
  sql: remove unused error codes, use enum instead of defines
  sql: simplify lua SQL executor
  sql: remove useless branching in insertOrReplace

 src/box/lua/sql.c       | 239 +++++++-----------------------------------------
 src/box/sql.c           |  18 ++--
 src/box/sql/analyze.c   |   8 +-
 src/box/sql/build.c     |   4 -
 src/box/sql/delete.c    |   2 +-
 src/box/sql/expr.c      |   5 +-
 src/box/sql/insert.c    |  80 ++++------------
 src/box/sql/main.c      |  32 -------
 src/box/sql/os_unix.c   |   9 +-
 src/box/sql/select.c    |  29 +++---
 src/box/sql/sqliteInt.h | 102 +++++++++++++--------
 src/box/sql/trigger.c   |   3 +-
 src/box/sql/update.c    |   6 +-
 src/box/sql/vdbe.c      |  10 +-
 src/box/sql/vdbeInt.h   |   5 +-
 src/box/sql/vdbeapi.c   |   9 --
 src/box/sql/vdbeaux.c   |   1 -
 src/box/sql/wherecode.c |   5 +-
 18 files changed, 152 insertions(+), 415 deletions(-)

-- 
2.14.3 (Apple Git-98)

             reply	other threads:[~2018-04-03 15:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 15:34 Vladislav Shpilevoy [this message]
2018-04-03 15:34 ` [tarantool-patches] [PATCH 1/4] sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace] Vladislav Shpilevoy
2018-04-03 23:01   ` [tarantool-patches] " n.pettik
2018-04-04 10:26     ` Vladislav Shpilevoy
2018-04-04 11:51       ` n.pettik
2018-04-04 14:48         ` n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 2/4] sql: remove unused error codes, use enum instead of defines Vladislav Shpilevoy
2018-04-03 23:01   ` [tarantool-patches] " n.pettik
2018-04-04 10:26     ` Vladislav Shpilevoy
2018-04-04 11:30       ` n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 3/4] sql: simplify lua SQL executor Vladislav Shpilevoy
2018-04-03 23:02   ` [tarantool-patches] " n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 4/4] sql: remove useless branching in insertOrReplace Vladislav Shpilevoy
2018-04-03 23:01   ` [tarantool-patches] " n.pettik
2018-04-05 11:43 ` [tarantool-patches] Re: [PATCH 0/4] sql: refactor insertion and lua Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1522769319.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 0/4] sql: refactor insertion and lua' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox