Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: kostja@tarantool.org
Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org
Subject: [PATCH 0/2] vinyl: zap upsert_format
Date: Fri, 30 Mar 2018 18:47:17 +0300	[thread overview]
Message-ID: <cover.1522423771.git.vdavydov.dev@gmail.com> (raw)

The sole purpose of a special format for UPSERT statements is that we
need to store UPSERT counter for them so that we can schedule UPSERT
squashing as soon as the number of UPSERTs for the same key exceeds a
certain threshold.

However, we only need to maintain the UPSERT counter for statements of
the memory level, so instead of maintaining yet another tuple format,
we can allocate the UPSERT counter on lsregion, near the tuple it is
for. This simplifies the code a great deal and eases implementation of
online ALTER.

https://github.com/tarantool/tarantool/tree/vy-zap-upsert-format

Vladimir Davydov (2):
  vinyl: allocate upsert counter on lsregion
  vinyl: zap upsert_format

 src/box/vinyl.c                 | 33 +++----------------
 src/box/vy_lsm.c                | 48 ++++++++-------------------
 src/box/vy_lsm.h                |  5 ---
 src/box/vy_mem.c                | 15 +++------
 src/box/vy_mem.h                |  6 +---
 src/box/vy_point_lookup.c       |  6 ++--
 src/box/vy_read_iterator.c      |  5 ++-
 src/box/vy_run.c                | 33 ++++++++-----------
 src/box/vy_run.h                | 11 ++-----
 src/box/vy_scheduler.c          |  8 ++---
 src/box/vy_stmt.c               | 72 ++++++++++++-----------------------------
 src/box/vy_stmt.h               | 49 +++++++++-------------------
 src/box/vy_tx.c                 |  9 ++----
 src/box/vy_upsert.c             | 11 +++----
 src/box/vy_upsert.h             |  3 +-
 src/box/vy_write_iterator.c     | 27 ++++++----------
 src/box/vy_write_iterator.h     |  8 ++---
 test/unit/vy_cache.c            | 11 +++----
 test/unit/vy_iterators_helper.c | 28 ++++++----------
 test/unit/vy_iterators_helper.h |  4 ---
 test/unit/vy_point_lookup.c     | 18 ++++-------
 test/unit/vy_write_iterator.c   |  6 ++--
 22 files changed, 125 insertions(+), 291 deletions(-)

-- 
2.11.0

             reply	other threads:[~2018-03-30 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 15:47 Vladimir Davydov [this message]
2018-03-30 15:47 ` [PATCH 1/2] vinyl: allocate upsert counter on lsregion Vladimir Davydov
2018-04-02 10:27   ` [tarantool-patches] " v.shpilevoy
2018-04-02 10:50     ` Vladimir Davydov
2018-03-30 15:47 ` [PATCH 2/2] vinyl: zap upsert_format Vladimir Davydov
2018-04-02 10:58   ` v.shpilevoy
2018-04-02 11:06     ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1522423771.git.vdavydov.dev@gmail.com \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [PATCH 0/2] vinyl: zap upsert_format' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox