From: AKhatskevich <avkhatskevich@tarantool.org>
To: tarantool-patches@freelists.org
Cc: AKhatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/3] Ephemeral tables perf leak & next rowid bug
Date: Thu, 29 Mar 2018 13:17:49 +0300 [thread overview]
Message-ID: <cover.1522318267.git.avkhatskevich@tarantool.org> (raw)
Key points:
- creater issue #3297 (OP_NextIdEphemeral produces wrong rowids)
- #3297 fixed for the most common case (but there still is code
in select.c which may fail because of the bug); the fix just
allocates register and increments it before each insert
- small mem leak fixed
AKhatskevich (3):
sql: Generate rowid by counter
sql: fix memory leak
sql: report errors in EphemeralGetMaxId
src/box/sql.c | 4 +++-
src/box/sql/insert.c | 10 +++++++++-
src/box/sql/select.c | 6 +++---
3 files changed, 15 insertions(+), 5 deletions(-)
--
2.14.1
next reply other threads:[~2018-03-29 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 10:17 AKhatskevich [this message]
2018-03-29 10:17 ` [tarantool-patches] [PATCH 1/3] sql: Generate rowid by counter AKhatskevich
2018-03-29 10:17 ` [tarantool-patches] [PATCH 2/3] sql: fix memory leak AKhatskevich
2018-03-29 10:17 ` [tarantool-patches] [PATCH 3/3] sql: report errors in EphemeralGetMaxId AKhatskevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1522318267.git.avkhatskevich@tarantool.org \
--to=avkhatskevich@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 0/3] Ephemeral tables perf leak & next rowid bug' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox