From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [tarantool-patches] [PATCH v2 0/3] console: do not use netbox for console text connections Date: Wed, 28 Mar 2018 16:35:47 +0300 [thread overview] Message-ID: <cover.1522243429.git.v.shpilevoy@tarantool.org> (raw) In-Reply-To: =?unknown-8bit?q?=3C20180326215549=2EGA5011=40atlas=3E=E2=81=A9?= Branch: http://github.com/tarantool/tarantool/tree/gh-2677-prepare-console-for-push Issue: https://github.com/tarantool/tarantool/issues/2677 Netbox console support complicates both netbox and console. Lets use sockets directly for text protocol. But the problem is that before a connection is established, the connection protocol is unknown (binary or text). It can be determined only when a greeting is read and decoded. After that the socket must be either wrapped by netbox API for binary connections, or by text console API for text connections. To be able to do that the new netbox functions are introduced: establish_connection and wrap. Netbox.establish_connection allows to connect to a server, read and decode greeting. Netbox.wrap creates a netbox state machine around a given socket. Vladislav Shpilevoy (3): netbox: allow to create a netbox connection from existing socket console: do not use netbox for console text connections netbox: deprecate console support src/box/lua/console.lua | 162 +++++++++++++++++++++++++++++------- src/box/lua/net_box.lua | 204 ++++++++++++++++++++++++++++++++-------------- test/box/net.box.result | 91 ++++++++++++++++++++- test/box/net.box.test.lua | 41 +++++++++- 4 files changed, 400 insertions(+), 98 deletions(-) -- 2.14.3 (Apple Git-98)
next reply other threads:[~2018-03-28 13:35 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-28 13:35 Vladislav Shpilevoy [this message] 2018-03-28 13:35 ` [tarantool-patches] [PATCH v2 1/3] netbox: allow to create a netbox connection from existing socket Vladislav Shpilevoy 2018-03-29 13:03 ` [tarantool-patches] " Konstantin Osipov 2018-03-28 13:35 ` [tarantool-patches] [PATCH v2 2/3] console: do not use netbox for console text connections Vladislav Shpilevoy 2018-03-29 13:03 ` [tarantool-patches] " Konstantin Osipov 2018-03-28 13:35 ` [tarantool-patches] [PATCH v2 3/3] netbox: deprecate console support Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1522243429.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v2 0/3] console: do not use netbox for console text connections' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox