From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [PATCH 0/3] console: do not use netbox for console text connections Date: Thu, 22 Mar 2018 22:17:09 +0300 [thread overview] Message-ID: <cover.1521745741.git.v.shpilevoy@tarantool.org> (raw) Branch: http://github.com/tarantool/tarantool/tree/gh-2677-prepare-console-for-push Issue: https://github.com/tarantool/tarantool/issues/2677 At first, netbox text protocol support is full of crutches, slows down a binary protocol support, and complicates a netbox implementation. At second, in #2677 text protocol will have two push types: print pushes, and YAML pushes. It can not be clearly supported in netbox, because it will contain only one callback to process pushed messages. Attempt to fit 3 push types (print, yaml, binary) into netbox will lead to even more complicated netbox. The text protocol must be supported by console only, and directly via sockets. Vladislav Shpilevoy (3): netbox: allow to create a netbox connection from existing socket console: do not use netbox for console text connections netbox: deprecate console support src/box/lua/console.lua | 178 +++++++++++++++++++++++++++++++++++++--------- src/box/lua/net_box.lua | 91 +++++++++++++++++------- test/box/net.box.result | 78 +++++++++++++++++++- test/box/net.box.test.lua | 33 ++++++++- 4 files changed, 318 insertions(+), 62 deletions(-) -- 2.14.3 (Apple Git-98)
next reply other threads:[~2018-03-22 19:17 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-22 19:17 Vladislav Shpilevoy [this message] 2018-03-22 19:17 ` [PATCH 1/3] netbox: allow to create a netbox connection from existing socket Vladislav Shpilevoy 2018-03-22 19:33 ` [tarantool-patches] " Konstantin Osipov 2018-03-22 19:50 ` v.shpilevoy 2018-03-22 19:57 ` [tarantool-patches] " v.shpilevoy 2018-03-23 10:01 ` [tarantool-patches] " v.shpilevoy 2018-03-26 21:55 ` Konstantin Osipov 2018-03-22 19:17 ` [PATCH 2/3] console: do not use netbox for console text connections Vladislav Shpilevoy 2018-03-22 19:36 ` [tarantool-patches] " Konstantin Osipov 2018-03-22 19:17 ` [PATCH 3/3] netbox: deprecate console support Vladislav Shpilevoy 2018-03-22 19:37 ` [tarantool-patches] " Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1521745741.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH 0/3] console: do not use netbox for console text connections' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox