From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Nikita Pettik <korablev@tarantool.org> Subject: [tarantool-patches] [PATCH 0/4] Remove space id and index id from cursor Date: Mon, 19 Mar 2018 21:10:36 +0300 [thread overview] Message-ID: <cover.1521479592.git.korablev@tarantool.org> (raw) Branch: https://github.com/tarantool/tarantool/tree/np/gh-3122-remove-pgnoRoot Issue: https://github.com/tarantool/tarantool/issues/3122 Before this patch, there was separate Tarantool specific cursor alongside with "ordinary" SQLite one. However, now only Tarantool spaces exist, so these two cursors can be merged into one. Moreover, there is no need to hold in cursor space and index id, since each appeal to them through cursor results in space lookup via BOX API. To avoid this overhead, pointers to space and index are stored in cursor (instead of ids) and DML executor is called explicitly. Nikita Pettik (4): Move space_is_system helper from CPP define guard sql: rework OP_Clear internals sql: remove struct ta_cursor and refactor BtCursor sql: replace pgnoRoot with struct space in BtCursor src/box/schema.h | 6 +- src/box/sql.c | 402 ++++++++++++++++++--------------------------- src/box/sql/cursor.c | 14 +- src/box/sql/cursor.h | 16 +- src/box/sql/opcodes.c | 2 +- src/box/sql/opcodes.h | 2 +- src/box/sql/tarantoolInt.h | 4 +- src/box/sql/vdbe.c | 63 +++---- src/box/sql/vdbeInt.h | 1 - 9 files changed, 206 insertions(+), 304 deletions(-) -- 2.15.1
next reply other threads:[~2018-03-19 18:10 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-19 18:10 Nikita Pettik [this message] 2018-03-19 18:10 ` [tarantool-patches] [PATCH 1/4] Move space_is_system helper from CPP define guard Nikita Pettik 2018-03-19 18:10 ` [tarantool-patches] [PATCH 2/4] sql: rework OP_Clear internals Nikita Pettik 2018-03-20 10:54 ` [tarantool-patches] " Kirill Yukhin 2018-03-20 12:27 ` n.pettik 2018-03-19 18:10 ` [tarantool-patches] [PATCH 3/4] sql: remove struct ta_cursor and refactor BtCursor Nikita Pettik 2018-03-19 18:10 ` [tarantool-patches] [PATCH 4/4] sql: replace pgnoRoot with struct space in BtCursor Nikita Pettik 2018-03-20 10:58 ` [tarantool-patches] " Kirill Yukhin 2018-03-20 12:28 ` n.pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1521479592.git.korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH 0/4] Remove space id and index id from cursor' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox