Tarantool development patches archive
 help / color / mirror / Atom feed
From: Timur Safin <tsafin@tarantool.org>
To: imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] lua: do not use internal api in public headers
Date: Mon, 20 Jul 2020 11:53:14 +0300	[thread overview]
Message-ID: <cf0d6098031fda5b8ee75104ec838c5e00b1b440.1595234591.git.tsafin@tarantool.org> (raw)

src/lua/utils.[ch] is part of public api which will
be integrated into module.h at the build step. It
should not refer to the internal LuaJIT API like
lj_state_growstack1(), otherwise it has not chance
to be linked in while building external binary module.

Relates to vshard-cluster-api#5
---

Branch: https://github.com/tarantool/tarantool/tree/tsafin/gh-vshard-cluster-api-5-no-private-api
Issue: https://github.com/tarantool/vshard-cluster-api/issues/5

 src/lua/utils.c | 13 +++++++++++++
 src/lua/utils.h | 14 ++------------
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/lua/utils.c b/src/lua/utils.c
index 0b05d7257..710d9c1fc 100644
--- a/src/lua/utils.c
+++ b/src/lua/utils.c
@@ -1054,6 +1054,19 @@ luaT_tolstring(lua_State *L, int idx, size_t *len)
 	return lua_tolstring(L, -1, len);
 }
 
+lua_State *
+luaT_newthread(lua_State *L)
+{
+	lua_State *L1 = NULL;
+	if (luaT_cpcall(L, luaT_newthread_wrapper, &L1) != 0) {
+		return NULL;
+	}
+	assert(L1 != NULL);
+	setthreadV(L, L->top, L1);
+	incr_top(L);
+	return L1;
+}
+
 /* Based on ffi_meta___call() from luajit/src/lib_ffi.c. */
 static int
 luaL_cdata_iscallable(lua_State *L, int idx)
diff --git a/src/lua/utils.h b/src/lua/utils.h
index b10754e4a..1e29d0f02 100644
--- a/src/lua/utils.h
+++ b/src/lua/utils.h
@@ -613,18 +613,8 @@ luaT_newthread_wrapper(lua_State *L)
  * @param L is a Lua State
  * @sa lua_newthread()
  */
-static inline lua_State *
-luaT_newthread(lua_State *L)
-{
-	lua_State *L1 = NULL;
-	if (luaT_cpcall(L, luaT_newthread_wrapper, &L1) != 0) {
-		return NULL;
-	}
-	assert(L1 != NULL);
-	setthreadV(L, L->top, L1);
-	incr_top(L);
-	return L1;
-}
+lua_State *
+luaT_newthread(lua_State *L);
 
 /**
  * Check if a value on @a L stack by index @a idx is an ibuf
-- 
2.20.1

             reply	other threads:[~2020-07-20  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20  8:53 Timur Safin [this message]
2020-07-20 11:34 ` Igor Munkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf0d6098031fda5b8ee75104ec838c5e00b1b440.1595234591.git.tsafin@tarantool.org \
    --to=tsafin@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] lua: do not use internal api in public headers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox