From: "Maxim Melentiev" <dmarc-noreply@freelists.org> (Redacted sender "m.melentiev" for DMARC)
To: Konstantin Osipov <kostja@tarantool.org>,
tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS
Date: Tue, 20 Aug 2019 18:26:02 +0300 [thread overview]
Message-ID: <cdf449c5-409d-0f8f-b371-cbe873f1c508@corp.mail.ru> (raw)
In-Reply-To: <20190819201827.GA21602@atlas>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
It's quite complicated now: cmake WITH_SYSTEMD flag is also used to
generate systemd units, tarantool-generator and other systemd related files.
I think that support for NOTIFY_SOCKET should not be systemd-related, as
it's enabled in runtime by envar and is disabled otherwise.
On 19/08/2019 23:18, Konstantin Osipov wrote:
>> -#if defined(WITH_SYSTEMD)
> I don't think you should remove this ifdef at all. Simply enable
> it on Mac OSX by default in cmake if it works there now.
>
[-- Attachment #2: Type: text/html, Size: 1003 bytes --]
next prev parent reply other threads:[~2019-08-20 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:28 [tarantool-patches] " Max Melentiev
2019-08-19 19:33 ` [tarantool-patches] " Alexander Turenko
2019-08-21 8:31 ` Maxim Melentiev
2019-08-21 15:52 ` Konstantin Osipov
2019-08-22 8:59 ` Maxim Melentiev
2019-08-22 10:06 ` Konstantin Osipov
2019-08-22 12:44 ` Maxim Melentiev
2019-08-22 13:03 ` Konstantin Osipov
2019-08-22 14:27 ` Maxim Melentiev
2019-08-23 12:11 ` Alexander Turenko
2019-08-27 23:51 ` Kirill Yukhin
2019-08-21 22:45 ` Alexander Turenko
2019-08-19 20:18 ` Konstantin Osipov
2019-08-20 15:26 ` Maxim Melentiev [this message]
2019-08-20 16:22 ` Konstantin Osipov
2019-08-27 23:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdf449c5-409d-0f8f-b371-cbe873f1c508@corp.mail.ru \
--to=dmarc-noreply@freelists.org \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox