From: Serge Petrenko <sergepetrenko@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/1] [tosquash] test: add a test for sync heartbeats Date: Thu, 25 Jun 2020 10:59:16 +0300 [thread overview] Message-ID: <cc57e1f9-25ef-e48c-6acf-2f82e975481e@tarantool.org> (raw) In-Reply-To: <923962ad34ef999c7e819b7a84891e204de23646.1592951940.git.v.shpilevoy@tarantool.org> Hi! Thanks for the patch! Please see 1 comment below. 24.06.2020 01:39, Vladislav Shpilevoy пишет: > Should be squashed into the commit closing 5100. > --- > Branch: http://github.com/tarantool/tarantool/tree/gh-4842-sync-replication > Issue: https://github.com/tarantool/tarantool/issues/4842 > > .../sync_replication_sanity.result | 50 +++++++++++++++++++ > .../sync_replication_sanity.test.lua | 22 ++++++++ > 2 files changed, 72 insertions(+) > > diff --git a/test/replication/sync_replication_sanity.result b/test/replication/sync_replication_sanity.result > index 4b9823d77..a0591dcf3 100644 > --- a/test/replication/sync_replication_sanity.result > +++ b/test/replication/sync_replication_sanity.result > @@ -178,6 +178,53 @@ box.space.sync:select{} > | - [3] > | ... > > +-- > +-- gh-5100: replica should send ACKs for sync transactions after > +-- WAL write immediately, not waiting for replication timeout or > +-- a CONFIRM. > +-- > +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} > + | --- > + | ... You should remember previous replication_timeout here and set it back during cleanup. Other than that, LGTM. > +test_run:switch('replica') > + | --- > + | - true > + | ... > +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} > + | --- > + | ... > +test_run:switch('default') > + | --- > + | - true > + | ... > +-- Commit something non-sync. So as applier writer fiber would > +-- flush the pending heartbeat and go to sleep with the new huge > +-- replication timeout. > +s = box.schema.create_space('test') > + | --- > + | ... > +pk = s:create_index('pk') > + | --- > + | ... > +s:replace{1} > + | --- > + | - [1] > + | ... > +-- Now commit something sync. It should return immediately even > +-- though the replication timeout is huge. > +box.space.sync:replace{4} > + | --- > + | - [4] > + | ... > +test_run:switch('replica') > + | --- > + | - true > + | ... > +box.space.sync:select{4} > + | --- > + | - - [4] > + | ... > + > -- Cleanup. > test_run:cmd('switch default') > | --- > @@ -195,6 +242,9 @@ test_run:cmd('delete server replica') > | --- > | - true > | ... > +box.space.test:drop() > + | --- > + | ... > box.space.sync:drop() > | --- > | ... > diff --git a/test/replication/sync_replication_sanity.test.lua b/test/replication/sync_replication_sanity.test.lua > index 8715a4600..f769804ca 100644 > --- a/test/replication/sync_replication_sanity.test.lua > +++ b/test/replication/sync_replication_sanity.test.lua > @@ -71,11 +71,33 @@ box.space.sync:select{} > test_run:cmd('restart server replica') > box.space.sync:select{} > > +-- > +-- gh-5100: replica should send ACKs for sync transactions after > +-- WAL write immediately, not waiting for replication timeout or > +-- a CONFIRM. > +-- > +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} > +test_run:switch('replica') > +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} > +test_run:switch('default') > +-- Commit something non-sync. So as applier writer fiber would > +-- flush the pending heartbeat and go to sleep with the new huge > +-- replication timeout. > +s = box.schema.create_space('test') > +pk = s:create_index('pk') > +s:replace{1} > +-- Now commit something sync. It should return immediately even > +-- though the replication timeout is huge. > +box.space.sync:replace{4} > +test_run:switch('replica') > +box.space.sync:select{4} > + > -- Cleanup. > test_run:cmd('switch default') > > box.cfg{replication_synchro_quorum=quorum, replication_synchro_timeout=timeout} > test_run:cmd('stop server replica') > test_run:cmd('delete server replica') > +box.space.test:drop() > box.space.sync:drop() > box.schema.user.revoke('guest', 'replication') -- Serge Petrenko
next prev parent reply other threads:[~2020-06-25 7:59 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 22:39 Vladislav Shpilevoy 2020-06-25 7:59 ` Serge Petrenko [this message] 2020-06-25 20:58 ` Vladislav Shpilevoy 2020-06-26 10:45 ` Serge Petrenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cc57e1f9-25ef-e48c-6acf-2f82e975481e@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/1] [tosquash] test: add a test for sync heartbeats' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox