From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v1 1/3] box: rfc for stacked diagnostic area in Tarantool Date: Tue, 6 Aug 2019 22:50:24 +0200 [thread overview] Message-ID: <cc1e4895-be03-a6c7-ce69-8525ddf7ac1d@tarantool.org> (raw) In-Reply-To: <06bd2140-3d2b-4bc3-7bc4-5f3d293bf891@tarantool.org> Hi! Thanks for the answers! CCed tarantool-patches back. On 06/08/2019 10:05, Kirill Shcherbatov wrote: >> 3. VShard uses unpack: https://github.com/tarantool/vshard/blob/a6826b26f9ab38e338a34cb7dd7f46dabbc67af5/vshard/error.lua#L149 >> Is it compatible with what you are doing? Here I need to turn an error into a table to >> set a different serialization method. >> >> 4. Have you considered an idea to unpack errors not as an array, but >> as a list? When each error object has a field 'reason' pointing to >> another object, and so on. It would allow not to change unpack() output >> format - it would still return the newest error, but with a new field. > > I designed :unpack() method to produce an output similar to backtrace. > But maybe it is not really our priority and taking into account your (3)th comment > we should better use reason-based list. Please, ask other people. >> 9. Please, describe the new binary protocol in the similar way as it >> is done here: https://github.com/tarantool/tarantool/blob/master/doc/rfc/3328-wire_protocol.md#body >> And add it to the docbot request with code values included. > > Is I sad in other letter, designing of iproto errors transfer may not be implemented in scope of this > patch series. Maybe it worth to remove this paragraph from RFC at all. > Ok, then remove, please, or move to a section 'plans', 'alternatives', etc.
next prev parent reply other threads:[~2019-08-06 20:48 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-01 11:13 [tarantool-patches] [PATCH v1 0/3] box: stacked diagnostics area in fiber Kirill Shcherbatov 2019-08-01 11:13 ` [tarantool-patches] [PATCH v1 1/3] box: rfc for stacked diagnostic area in Tarantool Kirill Shcherbatov 2019-08-05 21:16 ` [tarantool-patches] " Vladislav Shpilevoy [not found] ` <06bd2140-3d2b-4bc3-7bc4-5f3d293bf891@tarantool.org> 2019-08-06 20:50 ` Vladislav Shpilevoy [this message] 2019-08-07 23:27 ` Alexander Turenko 2019-08-08 20:46 ` Vladislav Shpilevoy 2019-08-08 23:29 ` Alexander Turenko 2019-08-09 19:25 ` Vladislav Shpilevoy 2019-08-12 20:35 ` Konstantin Osipov 2019-08-01 11:13 ` [tarantool-patches] [PATCH v1 2/3] box: stacked diagnostics area in fiber Kirill Shcherbatov 2019-08-05 21:16 ` [tarantool-patches] " Vladislav Shpilevoy 2019-08-01 11:13 ` [tarantool-patches] [PATCH v1 3/3] box: extend ffi error object API Kirill Shcherbatov 2019-08-05 21:18 ` [tarantool-patches] " Vladislav Shpilevoy 2019-08-06 7:56 ` Kirill Shcherbatov 2019-08-06 20:50 ` Vladislav Shpilevoy 2019-08-08 23:33 ` Alexander Turenko 2019-08-09 19:27 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cc1e4895-be03-a6c7-ce69-8525ddf7ac1d@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/3] box: rfc for stacked diagnostic area in Tarantool' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox