Re: [Tarantool-patches] [PATCH v2] rocks: forward options to luarocks

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch!

I added Yaroslav to CC since he expressed a will to join the
review.

On 05/04/2020 16:49, Leonid Vasiliev wrote:
> From: Leonid <lvasiliev@tarantool.org>
> 
> The policy for check of luarocks flags has been changed (moved from tarantoolctl to luarocks).

Usually there is a high tolerance to too long commit
message lines, but this is outstanding. Please, try to
keep it in 80 symbols top, 66 best.

> We had a white-list of luarocks options in tarantoolctl before.
> Now we have a black-list of options (for tarantool) in luarocks.

We don't have a blacklist anymore, from what I see. The
not supported options were just removed from the options
parser.

> Help section has been updated.

It was not.

> @TarantoolBot document
> Title: Update tarantoolctl rocks
> tarantoolctl rocks commands has been added:
> build
> config
> download
> init
> lint
> new_version
> purge
> which
> write_rockspec

Where a technical writer should take documentation
on these commands? Their arguments, options? Probably
there is a link describing all of them?

> Closes #4629
> ---
> https://github.com/tarantool/tarantool/issues/4629
> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4629-forward-flags