From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
sergos@tarantool.org, gorcunov@tarantool.org,
lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to use async txn_commit
Date: Sat, 27 Jun 2020 00:00:39 +0200 [thread overview]
Message-ID: <cbd18b54-2e3d-47af-77d2-c28af235e4bd@tarantool.org> (raw)
In-Reply-To: <6349f4ba-88c2-e6b4-1785-50e18dd5d010@tarantool.org>
On 23/06/2020 10:39, Serge Petrenko wrote:
>
> 23.06.2020 00:43, Vladislav Shpilevoy пишет:
>> I am looking at the commit which added on_write_failure.
>> Why can't we reuse on_rollback trigger? As we discussed,
>> we can pass whatever we want using txn->signature. So
>> for manual rollback we can set it to -1, for write failure
>> to -2, for limbo rollback to -3, for timeout to -4, etc.
>>
>> I am just afraid that +16 bytes for transaction object
>> may affect performance of the async transactions.
>
> We can. I've just done it & dropped the additionnal commit
>
> (the one that hacked the trigger removal in recovery.
We also can drop TXN_IS_ABORTED_BY_YIELD and reuse the signature
for this type of error too.
next prev parent reply other threads:[~2020-06-26 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 18:00 [Tarantool-patches] [PATCH 0/2] replication: support CONFIRM and ROLLBACK in recovery Serge Petrenko
2020-06-19 18:00 ` [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to use async txn_commit Serge Petrenko
2020-06-19 18:45 ` Serge Petrenko
2020-06-21 16:25 ` Vladislav Shpilevoy
2020-06-22 11:19 ` Serge Petrenko
2020-06-22 18:55 ` Serge Petrenko
2020-06-22 21:43 ` Vladislav Shpilevoy
2020-06-23 8:39 ` Serge Petrenko
2020-06-26 22:00 ` Vladislav Shpilevoy [this message]
2020-06-19 18:00 ` [Tarantool-patches] [PATCH 2/2] replication: support ROLLBACK and CONFIRM during recovery Serge Petrenko
2020-06-23 11:50 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd18b54-2e3d-47af-77d2-c28af235e4bd@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to use async txn_commit' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox