Tarantool development patches archive
 help / color / mirror / Atom feed
From: Artem via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCHv3 0/2] lua: fix tarantool -e always enters interactive mode
Date: Wed, 10 Mar 2021 16:00:20 +0300	[thread overview]
Message-ID: <cace9dc0-d15a-2f5a-ccbe-b289c39a7828@tarantool.org> (raw)
In-Reply-To: <6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 2626 bytes --]

Hi, thank you for the review!

05.03.2021 15:44, Leonid Vasiliev пишет:
> Hi!
> Please, add changelogs according to `doc/changelogs.md`.
Done. Added changelogs/unreleased/fix-tarantool-e-option.md 
<https://github.com/tarantool/tarantool/commit/fe750e977b30ca41975af9b78e56f70202c3024c#diff-c7ab331bb2558e469c1851f9d09ea8be0157b129af12a2370d2fbe77a12a378d> 

>
> On 3/4/21 12:15 PM, Artem Starshov wrote:
>> Issue: https://github.com/tarantool/tarantool/issues/5040
>> Branch: 
>> https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug
>> CI: https://github.com/tarantool/tarantool/runs/2029377964
>>
>> Changes in v3:
>>    * core:
>>      - add case-insensetive value for boolean error injection;
>>      - add more tests for setting error injections;
>>      - few refactored things (80 line width, alignment and etc.);
>>      - add release_disable for test;
>>      - add reference to test-run issue in commit message;
>>      - now, it is able to set errinjs via env ONLY in Debug mode.
>>    * lua:
>>      - some refactoring (name of variables, 80 line-width..);
>>      - add release_disable for test;
>>      - add reference to test-run issue in commit message;
>>      - add "errinj" to the name of the test;
>>      - add comments to source code.
>>
>> Artem Starshov (2):
>>    core: add setting error injections via env
>>    lua: fix tarantool -e always enters interactive mode
>>
>>   src/lib/core/errinj.c                         |  30 +++++
>>   src/lib/core/errinj.h                         |   6 +
>>   src/lua/init.c                                |  27 +++-
>>   src/main.cc                                   |   3 +
>>   ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++
>>   test/app-tap/suite.ini                        |   1 +
>>   .../errinj_set_with_enviroment_vars.test.lua  |  29 ++++
>>   ...errinj_set_with_enviroment_vars_script.lua |  34 +++++
>>   test/box-tap/suite.ini                        |   1 +
>>   test/box/errinj.result                        |   1 +
>>   10 files changed, 254 insertions(+), 4 deletions(-)
>>   create mode 100755 
>> test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua
>>   create mode 100755 
>> test/box-tap/errinj_set_with_enviroment_vars.test.lua
>>   create mode 100644 
>> test/box-tap/errinj_set_with_enviroment_vars_script.lua
>>

[-- Attachment #2: Type: text/html, Size: 4838 bytes --]

      reply	other threads:[~2021-03-10 13:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  9:15 Artem Starshov via Tarantool-patches
2021-03-04  9:15 ` [Tarantool-patches] [PATCHv3 1/2] core: add setting error injections via env Artem Starshov via Tarantool-patches
2021-03-05 12:11   ` Leonid Vasiliev via Tarantool-patches
2021-03-10 12:48     ` Artem via Tarantool-patches
2021-03-04  9:15 ` [Tarantool-patches] [PATCHv3 2/2] lua: fix tarantool -e always enters interactive mode Artem Starshov via Tarantool-patches
2021-03-05 12:31   ` Leonid Vasiliev via Tarantool-patches
2021-03-05 12:44 ` [Tarantool-patches] [PATCHv3 0/2] " Leonid Vasiliev via Tarantool-patches
2021-03-10 13:00   ` Artem via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cace9dc0-d15a-2f5a-ccbe-b289c39a7828@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=artemreyt@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCHv3 0/2] lua: fix tarantool -e always enters interactive mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox