From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] test: fix hanging of vinyl/[gh|iterator].test.lua
Date: Tue, 20 Oct 2020 22:46:48 +0200 [thread overview]
Message-ID: <caaa653e-95d9-5310-f554-d163c0f4ba7b@tarantool.org> (raw)
In-Reply-To: <020e17492aef4af6dd4065298a7fec7fa6082411.1603184379.git.avtikhon@tarantool.org>
Hi! Thanks for the patch!
> diff --git a/test/vinyl/gh.result b/test/vinyl/gh.result
> index 0fd74af83..5f568e7b1 100644
> --- a/test/vinyl/gh.result
> +++ b/test/vinyl/gh.result
> @@ -7,7 +7,14 @@ env = require('test_run')
> test_run = env.new()
> ---
> ...
> -fiber.sleep(1)
> +function box_snapshot() \
It would be good to have a comment here explaining why the function exists.
Otherwise it may look unclear why would anyone wrap box.snapshot.
LGTM.
prev parent reply other threads:[~2020-10-20 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:01 Alexander V. Tikhonov
2020-10-20 20:46 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caaa653e-95d9-5310-f554-d163c0f4ba7b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] test: fix hanging of vinyl/[gh|iterator].test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox