From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 51A45469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 20 Oct 2020 23:46:50 +0300 (MSK)
References: <020e17492aef4af6dd4065298a7fec7fa6082411.1603184379.git.avtikhon@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <caaa653e-95d9-5310-f554-d163c0f4ba7b@tarantool.org>
Date: Tue, 20 Oct 2020 22:46:48 +0200
MIME-Version: 1.0
In-Reply-To: <020e17492aef4af6dd4065298a7fec7fa6082411.1603184379.git.avtikhon@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3] test: fix hanging of
 vinyl/[gh|iterator].test.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

> diff --git a/test/vinyl/gh.result b/test/vinyl/gh.result
> index 0fd74af83..5f568e7b1 100644
> --- a/test/vinyl/gh.result
> +++ b/test/vinyl/gh.result
> @@ -7,7 +7,14 @@ env = require('test_run')
>  test_run = env.new()
>  ---
>  ...
> -fiber.sleep(1)
> +function box_snapshot()                                  \

It would be good to have a comment here explaining why the function exists.
Otherwise it may look unclear why would anyone wrap box.snapshot.

LGTM.