From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] memtx: fix tuples references on concurrent replaces
Date: Tue, 16 Jun 2020 13:07:07 +0300 [thread overview]
Message-ID: <ca94f2f8-33a0-452c-b578-d2d385c96488@tarantool.org> (raw)
In-Reply-To: <20200611221844.6511-1-i.kosarev@tarantool.org>
Great, lgtm now
On 6/12/20 1:18 AM, Ilya Kosarev wrote:
> Since 527b02a2ee6a9a205d8e2c8f38bbb84edf0d6557 (memtx: add yields
> during index build) memtx_build_on_replace was introduced to handle
> concurrent updates. The problem here was that the tuples being handled
> with this trigger did not get reference counter promotion, leading to a
> number of wrong behavior cases. Now this problem is solved.
> This problem was found through primary index altering with updates in
> background fiber. Corresponding test is introduced.
>
> Closes #4973
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4973-segfaults-on-alter
> Issue: https://github.com/tarantool/tarantool/issues/4973
>
> @ChangeLog:
> * Fix concurrent replaces on index building. Tuples are now referenced
> on all needed execution paths.
>
> Changes in v2:
> - stmt->new_tuple NULL case considered
> - respectively extended test
next prev parent reply other threads:[~2020-06-16 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 22:18 Ilya Kosarev
2020-06-16 10:07 ` Aleksandr Lyapunov [this message]
2020-06-16 10:41 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca94f2f8-33a0-452c-b578-d2d385c96488@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] memtx: fix tuples references on concurrent replaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox