From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 4/4] test: stabilize quorum test conditions
Date: Sun, 24 Nov 2019 16:54:13 +0100 [thread overview]
Message-ID: <ca1692e6-bda1-dd2d-cd89-dbe40ba6df65@tarantool.org> (raw)
In-Reply-To: <6e3ca8db565b415bd1a30ca1c52ea39fc9eb3976.1574545667.git.i.kosarev@tarantool.org>
Thanks for the patch!
> diff --git a/test/replication/quorum.result b/test/replication/quorum.result
> index ff5fa0150..939ce1e00 100644
> --- a/test/replication/quorum.result
> +++ b/test/replication/quorum.result
> @@ -64,6 +68,10 @@ box.info.ro -- true
> ---
> - true
> ...
> +test_run:wait_cond(function() return box.space.test ~= nil end, 20)
Why do you need the second wait for the same condition?
box.space.test was not dropped before this line, it should
still exist.
The same about all the similar checks for space.test.
next prev parent reply other threads:[~2019-11-24 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 21:53 [Tarantool-patches] [PATCH v2 0/4] fix box_set_replication issues & stabilize quorum test Ilya Kosarev
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 1/4] test: update test-run Ilya Kosarev
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 2/4] replication: fix appliers pruning Ilya Kosarev
2019-11-24 15:54 ` Vladislav Shpilevoy
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 3/4] replication: make anon replicas iteration safe Ilya Kosarev
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 4/4] test: stabilize quorum test conditions Ilya Kosarev
2019-11-24 15:54 ` Vladislav Shpilevoy [this message]
2019-11-24 15:53 ` [Tarantool-patches] [PATCH v2 0/4] fix box_set_replication issues & stabilize quorum test Vladislav Shpilevoy
2019-11-25 11:50 ` Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1692e6-bda1-dd2d-cd89-dbe40ba6df65@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 4/4] test: stabilize quorum test conditions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox