From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>,
Serge Petrenko <sergepetrenko@tarantool.org>
Cc: Mergen Imeev <imeevma@gmail.com>, tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] test: fix status at replication/misc*4424* test
Date: Thu, 3 Sep 2020 17:10:04 +0300 [thread overview]
Message-ID: <c9c6d67cd18cdabcd6a46d20f80afe7992869c89.1599142125.git.avtikhon@tarantool.org> (raw)
Fixed flaky status check:
[016] @@ -73,11 +73,11 @@
[016] ...
[016] box.info.status
[016] ---
[016] -- running
[016] +- orphan
[016] ...
[016] box.info.ro
[016] ---
[016] -- false
[016] +- true
[016] ...
[016] box.cfg{ \
[016] replication = {}, \
[016]
Test changed to use wait condition for the status check, which should
be changed from 'orphan' to 'running'. On heavy loaded hosts it may
spend some additional time, wait condition routine helped to fix it.
Closes #5271
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4940-replication-misc
Issue: https://github.com/tarantool/tarantool/issues/5271
.../misc_orphan_on_reconfiguration_error_gh-4424.result | 8 ++------
.../misc_orphan_on_reconfiguration_error_gh-4424.test.lua | 3 +--
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.result b/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.result
index c87ef2e05..110a0232d 100644
--- a/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.result
+++ b/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.result
@@ -65,13 +65,9 @@ box.info.ro
box.cfg{replication_connect_quorum=1}
---
...
-box.info.status
+test_run:wait_cond(function() return box.info.status == 'running' and box.info.ro == false end)
---
-- running
-...
-box.info.ro
----
-- false
+- true
...
box.cfg{ \
replication = {}, \
diff --git a/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.test.lua b/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.test.lua
index 6f42863c3..e35515aa5 100644
--- a/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.test.lua
+++ b/test/replication/misc_orphan_on_reconfiguration_error_gh-4424.test.lua
@@ -25,8 +25,7 @@ box.info.status
box.info.ro
-- lower quorum => leave orphan mode
box.cfg{replication_connect_quorum=1}
-box.info.status
-box.info.ro
+test_run:wait_cond(function() return box.info.status == 'running' and box.info.ro == false end)
box.cfg{ \
replication = {}, \
--
2.17.1
next reply other threads:[~2020-09-03 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:10 Alexander V. Tikhonov [this message]
2020-09-03 14:15 ` Serge Petrenko
2020-09-09 11:44 ` Kirill Yukhin
2020-09-09 11:53 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c6d67cd18cdabcd6a46d20f80afe7992869c89.1599142125.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=imeevma@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: fix status at replication/misc*4424* test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox