From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v5 0/6] box: run checks on insertions in LUA spaces
Date: Tue, 4 Jun 2019 20:59:25 +0200 [thread overview]
Message-ID: <c9b1e470-6023-c111-6eb7-7a3c8e5c31e1@tarantool.org> (raw)
In-Reply-To: <c99e6653-a605-75db-9faa-82a99325c02f@tarantool.org>
The patchset is LGTM. I've created a follow-up
issue: https://github.com/tarantool/tarantool/issues/4272
On 04/06/2019 10:21, Kirill Shcherbatov wrote:
>> Please, proceed with next patches. We need to
>> make a single Vdbe for all checks in a separate
>> commit.
>>
>> There is also a new proposal for benchmark. Lets
>> compare SQL CHECKs with tuple validation in Lua
>> before insertion, and see what is faster. Please,
>> write down somewhere all our planned benchmarks so
>> as no to forget something.
>>
>> Totally:
>> 1) bench CHECKs before your patch via pure SQL
>> 2) bench before your patch via checks done in Lua
>> before insertion
>> 3) bench after patch via pure SQL
>> 4) bench via Lua DML
>>
>> After single Vdbe is implemented, bench 3 and 4 again.
>
> Hi! Thank you for review an fixes! They are looking appropriately. I squashed them
> and fixed commit headers where necessary.
>
> I'll try to do what you've mention as soon as possible (don't know, what has higher
> priority - this or functional indexes fixes).
>
> However, can we merge the patch up to this point now?
>
next prev parent reply other threads:[~2019-06-04 18:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 10:19 [tarantool-patches] " Kirill Shcherbatov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 1/6] sql: introduce a new method to bind a pointer Kirill Shcherbatov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 2/6] sql: refactor OP_Column vdbe instruction Kirill Shcherbatov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 3/6] sql: introduce tuple_fetcher class Kirill Shcherbatov
2019-05-26 12:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-05-31 19:45 ` Konstantin Osipov
2019-05-31 19:50 ` Kirill Shcherbatov
2019-05-31 22:36 ` Vladislav Shpilevoy
2019-06-01 5:45 ` Konstantin Osipov
2019-06-02 18:50 ` Kirill Shcherbatov
2019-06-03 21:15 ` Vladislav Shpilevoy
2019-06-05 6:47 ` Konstantin Osipov
2019-06-05 6:48 ` Konstantin Osipov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 4/6] schema: add new system space for CHECK constraints Kirill Shcherbatov
2019-05-26 12:06 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-26 13:31 ` n.pettik
2019-05-26 13:32 ` Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-06-03 21:15 ` Vladislav Shpilevoy
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 5/6] box: run check constraint tests on space alter Kirill Shcherbatov
2019-05-26 12:07 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-06-03 21:15 ` Vladislav Shpilevoy
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 6/6] box: user-friendly interface to manage ck constraints Kirill Shcherbatov
2019-05-26 12:07 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-06-03 21:15 ` [tarantool-patches] Re: [PATCH v5 0/6] box: run checks on insertions in LUA spaces Vladislav Shpilevoy
2019-06-04 7:21 ` Kirill Shcherbatov
2019-06-04 18:59 ` Vladislav Shpilevoy [this message]
2019-06-06 11:58 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b1e470-6023-c111-6eb7-7a3c8e5c31e1@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v5 0/6] box: run checks on insertions in LUA spaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox