[tarantool-patches] Re: [PATCH 4/6] sql: make built-in functions operate on unsigned values

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the fixes! See 2 comments below.

> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
> index 2e8ac55e9..976b4486a 100644
> --- a/src/box/sql/sqlInt.h
> +++ b/src/box/sql/sqlInt.h
> @@ -395,13 +398,13 @@ void
>  sql_result_double(sql_context *, double);
>  
>  void
> -sql_result_int(sql_context *, int);
> +sql_result_uint(sql_context *ctx, uint64_t u_val);
>  
>  void
> -sql_result_bool(struct sql_context *ctx, bool value);
> +sql_result_int(sql_context *, int64_t);

1. Please, do not omit parameter names.

> diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c
> index 705e869bc..ff7ce658b 100644
> --- a/src/box/sql/vdbeapi.c
> +++ b/src/box/sql/vdbeapi.c
> @@ -320,21 +330,21 @@ sql_result_double(sql_context * pCtx, double rVal)
>  }
>  
>  void
> -sql_result_int(sql_context * pCtx, int iVal)
> +sql_result_uint(sql_context *ctx, uint64_t u_val)
>  {
> -	mem_set_i64(pCtx->pOut, iVal);
> +	mem_set_u64(ctx->pOut, u_val);
>  }
>  
>  void
> -sql_result_bool(struct sql_context *ctx, bool value)
> +sql_result_int(sql_context * pCtx, int64_t iVal)

2. In new code we usually use Tarantool code style - no
spaces after '*', and no camel case.

>  {
> -	mem_set_bool(ctx->pOut, value);
> +	mem_set_i64(pCtx->pOut, iVal);
>  }
>