From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org, imeevma@tarantool.org Subject: [tarantool-patches] Re: [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield() Date: Tue, 22 Jan 2019 22:58:52 +0300 [thread overview] Message-ID: <c72792bf-f5bb-e7fe-8277-0498a1284e05@tarantool.org> (raw) In-Reply-To: <f3d5e7ec4d7b75f81a022ce196fc2a8fdd4f5b98.1547902954.git.imeevma@gmail.com> Thanks for the fixes! > Diff between versions: > > commit 07bcff72336fe861fd51d895fe088662a9d09fe4 > Author: Mergen Imeev <imeevma@gmail.com> > Date: Thu Jan 17 15:00:27 2019 +0300 > > Temporary: Review fixes Please, do not merge diff of all comments into a single one. It is hardly possible to restore which part of this diff corresponds to which comment. Inline diff, fixing one comment, under this comment, like Nikita does. Also, I see that the branch still stores the old patchset. Please, push it. Until that I can not review it. > commit 3080ab1d7d2e8d8716ac91fc71150db7cde4ffe4 > Author: Mergen Imeev <imeevma@gmail.com> > Date: Fri Jan 11 21:16:12 2019 +0300 > > lua: remove exceptions from function luaL_tofield() > > Before this commit, the luaL_tofield() function threw a Lua > exception when an error occurred. This behavior has been changed > in this commit, now it sets diag_set() and returns -1 in case of > an error. > > Needed for ...3505 Please, use #, not ... .
next prev parent reply other threads:[~2019-01-22 19:59 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-19 13:20 [tarantool-patches] [PATCH v8 0/6] sql: remove box.sql.execute imeevma 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield() imeevma 2019-01-22 19:58 ` Vladislav Shpilevoy [this message] 2019-01-24 7:27 ` [tarantool-patches] " Imeev Mergen 2019-01-29 20:42 ` Vladislav Shpilevoy 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 2/6] iproto: move map creation to sql_response_dump() imeevma 2019-01-25 16:07 ` [tarantool-patches] " Konstantin Osipov 2019-01-29 20:42 ` Vladislav Shpilevoy 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 3/6] iproto: create port_sql imeevma 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 4/6] lua: create method dump_lua for port_sql imeevma 2019-01-29 20:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 5/6] lua: parameter binding for new execute() imeevma 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 6/6] sql: check new box.sql.execute() imeevma 2019-01-22 19:58 ` [tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute Vladislav Shpilevoy 2019-01-24 7:31 ` Imeev Mergen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c72792bf-f5bb-e7fe-8277-0498a1284e05@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox