From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Roman <roman.habibov@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] httpc: add checking of headers in httpc:request
Date: Sat, 16 Feb 2019 00:17:15 +0300 [thread overview]
Message-ID: <c617b48a-23d8-45c1-3157-d6e1a98ce531@tarantool.org> (raw)
In-Reply-To: <1549927450.14514.0@smtp.mail.ru>
Hi!
>> 5. Out of 80 symbols.
>>
>> 2. Still out of 80.
> My text editor shows 70 symbols.
>
Then there is something wrong with your editor, sorry.
https://github.com/tarantool/tarantool/blob/romanhabibov/gh-3679-httpc-request/src/lua/httpc.c#L180
Lets count. Here you have 6 tabs - 6 * 8 = 48 symbols. Then you have 55 symbols of
"headers must be string or table with \"__tostring\"");
48 + 55 = 103.
Also, the error string is not aligned by opening parenthesis.
In your email I see, that you have 4 symbols tab, what gives you 79 symbols, but
tab width in this file should be 8. So probably you mistakenly set tab width to
4 and the editor shows you < 80 width. Please, fix.
next prev parent reply other threads:[~2019-02-15 21:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 18:18 [tarantool-patches] " Roman Khabibov
2018-12-23 3:19 ` [tarantool-patches] " Alexander Turenko
2018-12-26 15:56 ` Roman
2018-12-29 10:30 ` Vladislav Shpilevoy
2019-01-09 13:29 ` Roman
2019-01-24 14:54 ` Roman
2019-01-29 19:44 ` Vladislav Shpilevoy
2019-01-29 20:32 ` Alexander Turenko
2019-01-31 23:47 ` Roman
2019-02-05 11:42 ` Vladislav Shpilevoy
2019-02-11 23:24 ` Roman
2019-02-15 21:17 ` Vladislav Shpilevoy [this message]
2019-02-19 10:49 ` Roman
2019-02-22 16:01 ` Vladislav Shpilevoy
2019-02-23 21:38 ` Roman Khabibov
2019-02-23 22:43 ` Roman Khabibov
2019-02-25 13:04 ` Vladislav Shpilevoy
2019-02-25 14:51 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c617b48a-23d8-45c1-3157-d6e1a98ce531@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] httpc: add checking of headers in httpc:request' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox