From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "n.pettik@corp.mail.ru" <n.pettik@corp.mail.ru>
Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: unset pragma in transitive-transactions test
Date: Thu, 21 Jun 2018 19:06:04 +0300 [thread overview]
Message-ID: <c5ca4763-b7e4-af41-b40e-6541a0c34a93@tarantool.org> (raw)
In-Reply-To: <EA90AF09-D59E-4710-983F-D27F34E063DE@tarantool.org>
On 21.06.2018 18:45, n.pettik wrote:
>
>> +box.sql.execute('PRAGMA defer_foreign_keys = 0;')
>> +box.sql.execute('pragma foreign_keys = 0;’);
>
> Could you please explain, why do you need to turn off foreign keys?
> AFAIK by default they are enabled. It is okay to change defer mode, but
> I see no reason to disable them at all.
Yes, I've already dropped this line on branch. This was an extra diff.
I've tried to undone all settings that you apply. Disable defer_foreign_keys is really enough.
next prev parent reply other threads:[~2018-06-21 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 15:55 [tarantool-patches] [PATCH v1 0/2] SQL Tests failed on concurrent launch Kirill Shcherbatov
2018-06-20 15:55 ` [tarantool-patches] [PATCH v1 1/2] sql: finish clean-up in view_delayed_wal test Kirill Shcherbatov
2018-06-21 15:48 ` [tarantool-patches] " n.pettik
2018-06-20 15:55 ` [tarantool-patches] [PATCH v1 2/2] sql: unset pragma in transitive-transactions test Kirill Shcherbatov
2018-06-21 15:45 ` [tarantool-patches] " n.pettik
2018-06-21 16:06 ` Kirill Shcherbatov [this message]
2018-06-25 13:39 ` [tarantool-patches] Re: [PATCH v1 0/2] SQL Tests failed on concurrent launch Kirill Shcherbatov
2018-06-25 13:42 ` n.pettik
2018-06-26 8:01 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ca4763-b7e4-af41-b40e-6541a0c34a93@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=n.pettik@corp.mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/2] sql: unset pragma in transitive-transactions test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox