From: Ilya Kosarev <i.kosarev@tarantool.org> To: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 1/2] replication: make anon replicas iteration safe Date: Mon, 18 Nov 2019 16:19:42 +0300 [thread overview] Message-ID: <c4cf9830e031feefd22ed0068c7ef1b44dfb860a.1574082067.git.i.kosarev@tarantool.org> (raw) In-Reply-To: <cover.1574082067.git.i.kosarev@tarantool.org> In-Reply-To: <cover.1574082067.git.i.kosarev@tarantool.org> In replicaset_follow we iterate anon replicas list: list of replicas that haven't received an UUID. In case of successful connect replica link is being removed from anon list. If it happens immediately, without yield in applier, iteration breaks. Now it is fixed by rlist_foreach_entry_safe instead of common rlist_foreach_entry. Part of #4586 --- src/box/replication.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/box/replication.cc b/src/box/replication.cc index 509187cd3..495a01c4f 100644 --- a/src/box/replication.cc +++ b/src/box/replication.cc @@ -800,7 +800,8 @@ replicaset_follow(void) if (replica->applier != NULL) applier_resume(replica->applier); } - rlist_foreach_entry(replica, &replicaset.anon, in_anon) { + struct replica *tmp; + rlist_foreach_entry_safe(replica, &replicaset.anon, in_anon, tmp) { /* Restart appliers that failed to connect. */ applier_start(replica->applier); } -- 2.17.1
next prev parent reply other threads:[~2019-11-18 13:19 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-18 13:19 [Tarantool-patches] [PATCH 0/2] fix replica iteration issue & stabilize quorum test Ilya Kosarev 2019-11-18 13:19 ` Ilya Kosarev [this message] 2019-11-18 13:19 ` [Tarantool-patches] [PATCH 2/2] test: stabilize quorum test conditions Ilya Kosarev 2019-11-19 23:13 ` [Tarantool-patches] [PATCH 0/2] fix replica iteration issue & stabilize quorum test Vladislav Shpilevoy 2019-11-20 1:29 ` Ilya Kosarev 2019-11-20 1:41 ` Ilya Kosarev 2019-11-20 22:18 ` Vladislav Shpilevoy 2019-11-20 22:48 ` Ilya Kosarev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c4cf9830e031feefd22ed0068c7ef1b44dfb860a.1574082067.git.i.kosarev@tarantool.org \ --to=i.kosarev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] replication: make anon replicas iteration safe' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox