Re: [Tarantool-patches] [PATCH 4/6] sql: remove mem_apply_type() from OP_MustBeInt

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch!

See 2 comments below.

> diff --git a/test/sql-tap/join.test.lua b/test/sql-tap/join.test.lua
> index 840b780a3..51e0ecb79 100755
> --- a/test/sql-tap/join.test.lua
> +++ b/test/sql-tap/join.test.lua
> @@ -1034,7 +1034,6 @@ test:do_execsql_test(
>          SELECT * FROM t1 NATURAL JOIN t2
>      ]], {
>          -- <join-11.9>
> -        "one", "1", "two", "2"
>          -- </join-11.9>
>      })

1. Why does "join-11.10" still work? I see it started failing
in the next commits, but why not here?

> diff --git a/test/sql-tap/tkt-9a8b09f8e6.test.lua b/test/sql-tap/tkt-9a8b09f8e6.test.lua
> index cb5348ab4..854ed774f 100755
> --- a/test/sql-tap/tkt-9a8b09f8e6.test.lua
> +++ b/test/sql-tap/tkt-9a8b09f8e6.test.lua
> @@ -189,7 +189,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE x IN ('1');
>      ]], {
>          -- <3.3>
> -        1
>          -- </3.3>
>      })
> 
> @@ -199,7 +198,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE x IN ('1');
>      ]], {
>          -- <3.4>
> -        1
>          -- </3.4>
>      })
> 
> @@ -229,7 +227,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE '1' IN (x);
>      ]], {
>          -- <3.7>
> -        1
>          -- </3.7>
>      })
> 
> @@ -239,7 +236,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE '1' IN (x);
>      ]], {
>          -- <3.8>
> -        1
>          -- </3.8>

2. 3.7 and 3.8 are absolutely the same. Maybe better to drop
one of them. The same about 3.4 <-> 3.3.