From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>,
"Alexander V . Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] popen fixes
Date: Mon, 18 May 2020 23:57:06 +0200 [thread overview]
Message-ID: <c44cbb04-5e3e-f05e-4212-13cea211c125@tarantool.org> (raw)
In-Reply-To: <cover.1589799677.git.alexander.turenko@tarantool.org>
Hi! Thanks for the patchset!
It works on my machine, LGTM.
On 18/05/2020 13:42, Alexander Turenko wrote:
> The patchset fixes two problems in the popen implementation and the
> test, which fails testing on Mac OS from time to time.
>
> https://github.com/tarantool/tarantool/issues/4995
> https://github.com/tarantool/tarantool/issues/4938
> Totktonada/popen-fixes
>
> Alexander Turenko (2):
> popen: fix access to freed memory after :close()
> test: popen: fix popen test 'hang' under test-run
>
> src/lib/core/popen.c | 5 +++++
> src/lua/popen.c | 11 +++++++++--
> test/app-tap/popen.test.lua | 24 +++++++++++++++++++++++-
> 3 files changed, 37 insertions(+), 3 deletions(-)
>
next prev parent reply other threads:[~2020-05-18 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:42 Alexander Turenko
2020-05-18 11:42 ` [Tarantool-patches] [PATCH 1/2] popen: fix access to freed memory after :close() Alexander Turenko
2020-05-18 11:42 ` [Tarantool-patches] [PATCH 2/2] test: popen: fix popen test 'hang' under test-run Alexander Turenko
2020-05-18 21:57 ` Vladislav Shpilevoy [this message]
2020-05-19 5:00 ` [Tarantool-patches] [PATCH 0/2] popen fixes Alexander V. Tikhonov
2020-05-20 6:35 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c44cbb04-5e3e-f05e-4212-13cea211c125@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] popen fixes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox