From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove redundant goto from VDBE prologue
Date: Tue, 19 Jun 2018 00:03:52 +0300 [thread overview]
Message-ID: <c3fcb1d9-6910-db42-2c7d-c5549d3bf1b9@tarantool.org> (raw)
In-Reply-To: <83377E01-A80A-41A3-ACD9-939DF6CD2910@tarantool.org>
Thanks. Now LGTM.
On 18/06/2018 23:55, n.pettik wrote:
>
>>> Thx for refactoring, but it wouldn’t work this way:
>>> We must firstly make lable to jump (sqlite3VdbeJumpHere(v, 0);),
>>> then test on emitting OP_TTransaction and const exprs (or both). If we need to
>>> add such opcodes, then we should jump back. Otherwise, dismiss initial jump.
>>
>> We do not need to change P2 until it is really needed. That is what I
>> mean.
>
> Ok, my apologies for misunderstanding. I pushed your changes.
>
next prev parent reply other threads:[~2018-06-18 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 18:26 [tarantool-patches] " Nikita Pettik
2018-06-17 20:08 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-18 10:46 ` n.pettik
2018-06-18 11:06 ` Vladislav Shpilevoy
2018-06-18 17:45 ` n.pettik
2018-06-18 18:57 ` Vladislav Shpilevoy
2018-06-18 20:55 ` n.pettik
2018-06-18 21:03 ` Vladislav Shpilevoy [this message]
2018-06-19 8:21 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3fcb1d9-6910-db42-2c7d-c5549d3bf1b9@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove redundant goto from VDBE prologue' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox