Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario
Date: Thu,  5 Jun 2025 08:44:18 +0300	[thread overview]
Message-ID: <c3fc5e24abd3112b5f0017d67cdec239c911d8ce.1749101434.git.skaplun@tarantool.org> (raw)
In-Reply-To: <cover.1749101434.git.skaplun@tarantool.org>

This patch adds a new field, track-fds [1], in the Valgrind workflow
matrix to detect descriptor leakage in the tests.

[1]: https://valgrind.org/docs/manual/manual-core.html#opt.track-fds

Needed for tarantool/tarantool#11278
---
 .github/workflows/valgrind-testing.yaml | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/valgrind-testing.yaml b/.github/workflows/valgrind-testing.yaml
index e6606478..b3c7bc80 100644
--- a/.github/workflows/valgrind-testing.yaml
+++ b/.github/workflows/valgrind-testing.yaml
@@ -38,7 +38,11 @@ jobs:
         # Therefore, testing on this platform is currently
         # disabled.
         BUILDTYPE: [Debug, Release]
-        VALGRIND_SCENARIO: [full, malloc-free-fill-0x00, malloc-free-fill-0xff]
+        VALGRIND_SCENARIO:
+          - full
+          - malloc-free-fill-0x00
+          - malloc-free-fill-0xff
+          - track-fds
         include:
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -59,6 +63,9 @@ jobs:
           - VALGRIND_SCENARIO: malloc-free-fill-0xff
             VALGRIND_OPTS: --leak-check=no --malloc-fill=0xff --free-fill=0xff
             JOB_POSTFIX: "malloc/free-fill: 0xff"
+          - VALGRIND_SCENARIO: track-fds
+            VALGRIND_OPTS: --leak-check=no --track-fds=yes
+            JOB_POSTFIX: "track-fds"
     runs-on: [self-hosted, regular, Linux, x86_64]
     name: >
       LuaJIT with Valgrind (Linux/x86_64)
-- 
2.49.0


  reply	other threads:[~2025-06-05  5:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  5:44 [Tarantool-patches] [PATCH luajit 0/3] Fix descriptor leak in loadfile Sergey Kaplun via Tarantool-patches
2025-06-05  5:44 ` Sergey Kaplun via Tarantool-patches [this message]
2025-06-06 13:56   ` [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario Sergey Bronnikov via Tarantool-patches
2025-06-06 14:03     ` Sergey Kaplun via Tarantool-patches
2025-06-06 14:54       ` Sergey Bronnikov via Tarantool-patches
2025-06-06 15:31         ` Sergey Kaplun via Tarantool-patches
2025-06-05  5:44 ` [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*() Sergey Kaplun via Tarantool-patches
2025-06-06 14:47   ` Sergey Bronnikov via Tarantool-patches
2025-06-06 15:14     ` Sergey Kaplun via Tarantool-patches
2025-06-06 15:49       ` Sergey Bronnikov via Tarantool-patches
2025-06-05  5:44 ` [Tarantool-patches] [PATCH luajit 3/3] Fix another " Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3fc5e24abd3112b5f0017d67cdec239c911d8ce.1749101434.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox