From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>,
Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking
Date: Thu, 18 Jun 2020 00:30:33 +0200 [thread overview]
Message-ID: <c308cbd4-b1cf-1368-96a5-6d8216ceaa8b@tarantool.org> (raw)
In-Reply-To: <cover.1589321083.git.alexander.turenko@tarantool.org>
Generally the patchset is fine, except one commit for the last
commit.
However the 'feature' about implicit box.cfg call should be
deleted, IMO. It only brings complexity to the code. No one
ever asked for it. Its purpose was to allow to do box.cfg from
SQL console, but there is no a problem in doing it manually
before touching SQL. Anyway nobody uses box.cfg without parameters
except for small manual tests. Note,
box.execute('SELECT lua("box.cfg ...")') won't work, because VDBE
and the parser heavily depend on the initialized box.
next prev parent reply other threads:[~2020-06-17 22:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 22:18 Alexander Turenko
2020-05-12 22:18 ` [Tarantool-patches] [PATCH 1/3] box: check whether box is loaded in box.execute() Alexander Turenko
2020-05-22 7:31 ` lvasiliev
2020-06-03 21:58 ` Igor Munkin
2020-06-08 18:58 ` Alexander Turenko
2020-06-11 17:43 ` Igor Munkin
2020-05-12 22:18 ` [Tarantool-patches] [PATCH 2/3] box: always wait box loading " Alexander Turenko
2020-05-22 11:08 ` lvasiliev
2020-06-03 23:12 ` Igor Munkin
2020-05-12 22:18 ` [Tarantool-patches] [PATCH 3/3] box: always reconfigure box at non-first box.cfg() Alexander Turenko
2020-05-22 7:02 ` lvasiliev
2020-06-03 22:41 ` Igor Munkin
2020-06-03 23:22 ` Igor Munkin
2020-06-08 18:59 ` Alexander Turenko
2020-06-17 22:26 ` Vladislav Shpilevoy
2020-06-18 8:41 ` Alexander Turenko
2020-06-18 22:23 ` Vladislav Shpilevoy
2020-05-22 7:06 ` [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking lvasiliev
2020-06-08 18:59 ` Alexander Turenko
2020-06-17 22:30 ` Vladislav Shpilevoy [this message]
2020-06-22 10:11 ` Kirill Yukhin
2020-06-23 23:55 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c308cbd4-b1cf-1368-96a5-6d8216ceaa8b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox