From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/4] replication: run clear_synchro_queue() with unconfigured box
Date: Mon, 23 Nov 2020 17:44:25 +0300 [thread overview]
Message-ID: <c2de21c8-1fc6-cdae-f688-7a9cc009437e@tarantool.org> (raw)
In-Reply-To: <d5445975-3272-8597-0766-930171b01b3d@tarantool.org>
Hi! Thanks for review!
On 21.11.2020 17:41, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> From the commit title it seems like you introduced a feature to run
> the function with non-configured box. Please, change 'run' to 'test',
> would be better already.
>
> Also for qsync we usually write title 'qsync: ...', not just
> 'replication: ...'. Or in your case it could be 'test: ...',
> but up to you. The same for the other commits.
updated prefix for all commits in patch series:
4f8b516c3 (HEAD -> ligurio/gh-4842-qsync-testing) qsync: add test with
change space sync mode in a loop
d9a3fff52 qsync: add test with random leaders promotion and demotion
8723e4cca qsync: test clear_synchro_queue() function
8889406fc qsync: test clear_synchro_queue() with unconfigured box
> The patch itself is good.
next prev parent reply other threads:[~2020-11-23 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 16:13 [Tarantool-patches] [PATCH 0/4 v3] Additional qsync tests sergeyb
2020-11-17 16:13 ` [Tarantool-patches] [PATCH 1/4] replication: run clear_synchro_queue() with unconfigured box sergeyb
2020-11-21 14:41 ` Vladislav Shpilevoy
2020-11-23 14:44 ` Sergey Bronnikov [this message]
2020-11-17 16:13 ` [Tarantool-patches] [PATCH 2/4] replication: test clear_synchro_queue() function sergeyb
2020-11-21 14:41 ` Vladislav Shpilevoy
2020-11-23 15:13 ` Sergey Bronnikov
2020-11-17 16:13 ` [Tarantool-patches] [PATCH 3/4] replication: add test with random leaders promotion and demotion sergeyb
2020-11-21 14:41 ` Vladislav Shpilevoy
2020-11-24 8:39 ` Sergey Bronnikov
2020-11-25 22:02 ` Vladislav Shpilevoy
2020-11-17 16:13 ` [Tarantool-patches] [PATCH 4/4] replication: add test with change space sync mode in a loop sergeyb
2020-11-21 14:41 ` Vladislav Shpilevoy
2020-11-23 15:42 ` Sergey Bronnikov
2020-11-25 22:02 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2de21c8-1fc6-cdae-f688-7a9cc009437e@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/4] replication: run clear_synchro_queue() with unconfigured box' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox