From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Timur Safin <tsafin@tarantool.org>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] cmake: remove double usage of some source files
Date: Sat, 18 Apr 2020 18:51:14 +0200 [thread overview]
Message-ID: <c2dceb51-c112-20ee-8ace-570ad4bbe8f5@tarantool.org> (raw)
In-Reply-To: <203a01d61562$f09ba9c0$d1d2fd40$@tarantool.org>
Hi! Thanks for the review!
> : diff --git a/src/lib/small b/src/lib/small
> : index 3df505017..cebc40574 160000
> : --- a/src/lib/small
> : +++ b/src/lib/small
> : @@ -1 +1 @@
> : -Subproject commit 3df5050171d040bfe5717b4bddf57da3b312ffe4
> : +Subproject commit cebc40574cb68a21dac16c438371392db8f98f66
>
> Have you intentionally moved small submodule? Is it necessary for this case?
No, that was an accident. Reverted.
next prev parent reply other threads:[~2020-04-18 16:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 23:48 [Tarantool-patches] [PATCH v2 0/2] Unhide symbols Vladislav Shpilevoy
2020-04-17 23:48 ` [Tarantool-patches] [PATCH v2 1/2] cmake: remove double usage of some source files Vladislav Shpilevoy
2020-04-18 9:22 ` Timur Safin
2020-04-18 16:51 ` Vladislav Shpilevoy [this message]
2020-04-17 23:48 ` [Tarantool-patches] [PATCH v2 2/2] cmake: remove dynamic-list linker option Vladislav Shpilevoy
2020-04-18 12:39 ` Timur Safin
2020-04-18 16:51 ` Vladislav Shpilevoy
2020-04-18 22:07 ` Timur Safin
2020-04-22 22:08 ` [Tarantool-patches] [PATCH v2 0/2] Unhide symbols Vladislav Shpilevoy
2020-04-22 23:27 ` Timur Safin
2020-04-24 7:47 ` Kirill Yukhin
2020-04-27 10:44 ` Timur Safin
2020-04-27 21:38 ` Vladislav Shpilevoy
2020-04-27 22:58 ` Vladislav Shpilevoy
2020-05-18 21:32 ` Vladislav Shpilevoy
2020-05-19 9:02 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2dceb51-c112-20ee-8ace-570ad4bbe8f5@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] cmake: remove double usage of some source files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox