From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org Subject: [tarantool-patches] Re: [PATCH 1/1] box: raise an error on nil replicaset and instance uuid Date: Sat, 7 Sep 2019 15:28:35 +0200 [thread overview] Message-ID: <c2d380c0-7121-5f10-f2e8-d6b6547cdcab@tarantool.org> (raw) In-Reply-To: <b424e0e94fda981935112071924c6b33c41e00ce.1567862614.git.v.shpilevoy@tarantool.org> On 07/09/2019 15:26, Vladislav Shpilevoy wrote: > Before the patch the nil UUID was ignored and a new random one > was generated. This was because internally box treats nil UUID > as its absense. 'absense' -> 'absence'. > > Now a user will see an explicit message that nil UUID is a > reserved value. > > Closes #4282 > --- > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid > Issue: https://github.com/tarantool/tarantool/issues/4282 > > src/box/box.cc | 25 +++++++++++++++++-------- > test/app-tap/cfg.test.lua | 12 +++++++++++- > 2 files changed, 28 insertions(+), 9 deletions(-) > > diff --git a/src/box/box.cc b/src/box/box.cc > index ac10c21ad..5efc88d5f 100644 > --- a/src/box/box.cc > +++ b/src/box/box.cc > @@ -480,22 +480,31 @@ box_check_replication_sync_timeout(void) > return timeout; > } > > +static inline void > +box_check_uuid(struct tt_uuid *uuid, const char* name) Sorry, '*' should be right before 'name'. (Messed with Ubisoft code style)
next prev parent reply other threads:[~2019-09-07 13:25 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-07 13:26 [tarantool-patches] " Vladislav Shpilevoy 2019-09-07 13:28 ` Vladislav Shpilevoy [this message] 2019-09-08 12:27 ` [tarantool-patches] " Vladislav Shpilevoy 2019-10-16 0:12 ` [Tarantool-patches] " Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c2d380c0-7121-5f10-f2e8-d6b6547cdcab@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH 1/1] box: raise an error on nil replicaset and instance uuid' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox