Tarantool development patches archive
 help / color / mirror / Atom feed
From: Safin Timur via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>, imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: bit-wise operations now accepts only UNSIGNED
Date: Thu, 5 Aug 2021 16:28:45 +0300	[thread overview]
Message-ID: <c0cfdcb6-6ae0-b8d9-cbcd-27ab07be7474@tarantool.org> (raw)
In-Reply-To: <20210805095731.7jtgqmpqtzy6v623@tarantool.org>

This patch, if unmodified, breaks 2.7, and 2.8 due to failing test 
test/sql-tap/gh-5364-define-bit-wise-rules.test.lua

Could you or Mergen please remome UUID subtests (2.7, 3.7, 4.7) which 
are incompatible (due to missing UUID) with 2.7 and 2.8 code base?

Thanks,
Timur

On 05.08.2021 12:57, Kirill Yukhin via Tarantool-patches wrote:
> Hello,
> 
> On 04 авг 11:26, imeevma@tarantool.org wrote:
>> After this patch, bitwise operations will only accept UNSIGNED and
>> positive INTEGER values as operands. The result of the bitwise operand
>> will be UNSIGNED.
>>
>> Part of #4470
>> Closes #5364
>> ---
>> https://github.com/tarantool/tarantool/issues/5364
>> https://github.com/tarantool/tarantool/tree/imeevma/gh-5364-fix-bitwise-operations
> 
> I've checked your patch into 2.7, 2.8 and master.
> 
> --
> Regards, Kirill Yukhin
> 

  reply	other threads:[~2021-08-05 13:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  8:26 Mergen Imeev via Tarantool-patches
2021-08-04 14:05 ` Kirill Yukhin via Tarantool-patches
2021-08-04 15:15   ` Vitaliia Ioffe via Tarantool-patches
2021-08-05  9:57 ` Kirill Yukhin via Tarantool-patches
2021-08-05 13:28   ` Safin Timur via Tarantool-patches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-02 17:09 Mergen Imeev via Tarantool-patches
2021-07-29 23:05 Mergen Imeev via Tarantool-patches
2021-07-23  9:55 Mergen Imeev via Tarantool-patches
2021-07-26 21:12 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-27  9:02   ` Mergen Imeev via Tarantool-patches
2021-07-26 21:54 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-27  9:10   ` Mergen Imeev via Tarantool-patches
2021-07-29 20:49 ` Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0cfdcb6-6ae0-b8d9-cbcd-27ab07be7474@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tsafin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: bit-wise operations now accepts only UNSIGNED' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox