From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D1EBA71211; Thu, 5 Aug 2021 16:28:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D1EBA71211 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628170127; bh=OpG3UTVz9RJGUjlLfTTi/lJ+UPT+4V2y5Yw/uoVvWLA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=f+Fwy675+nBL4fm014Y7eoKHaAjX8oa2mJ0KCTcXogySrZUr0Zg0UNHVlkHgqaecX HZC2TQU5+IaE+fUbTSGt+TkdeJPLjHt3gfUJuH/ORef0AZAK8q6X355MQpMKpekY5G sntMoauxTqJP3gNgdjgDbL7VogpgVfYG3C3N4JX4= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FE9071211 for ; Thu, 5 Aug 2021 16:28:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FE9071211 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1mBdQT-0007Z6-WC; Thu, 05 Aug 2021 16:28:46 +0300 To: Kirill Yukhin , imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <20210805095731.7jtgqmpqtzy6v623@tarantool.org> Message-ID: Date: Thu, 5 Aug 2021 16:28:45 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805095731.7jtgqmpqtzy6v623@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD906AB4890CDABF0C5CB76CEE71D3E4007182A05F5380850404E423465BA2629574232E74B70CD12BF88C363F837669C31960B86CF0DF508AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748744D4CD6EC491D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8785AD8DE8F60F5BFEA9D79D35D7171C1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC908CD1B87A134A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BA5FD2DD08EB4836CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3568FCE88E0C8489DAD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A7EFCB0EB5ACB161EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505117082C42E57F89076AF8084D0130D6F X-C1DE0DAB: 0D63561A33F958A537D55BB02FF7E4F1CA69A0BAE8A88DBEDD0A82424E3E7E3AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340E23B77EA180781781D1D10AA201A8C748676EAE30C39120D7E80E7D6E644F320CBD3BB73759699C1D7E09C32AA3244CC6DFCBCFD6146EB9EAFB68E582AB618995A9E0DC41E9A4CFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3XhfIsE0IQcVA== X-Mailru-Sender: B5B6A6EBBD94DAD81091F6801AA03C01525AD8EFB991A4CE518925661BC0A933165A83FEA1C23F2B5C2808D6142752370A8ED71B308007E3DC85537438B7E1A423D748DE48713E689437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: bit-wise operations now accepts only UNSIGNED X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Safin Timur via Tarantool-patches Reply-To: Safin Timur Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This patch, if unmodified, breaks 2.7, and 2.8 due to failing test test/sql-tap/gh-5364-define-bit-wise-rules.test.lua Could you or Mergen please remome UUID subtests (2.7, 3.7, 4.7) which are incompatible (due to missing UUID) with 2.7 and 2.8 code base? Thanks, Timur On 05.08.2021 12:57, Kirill Yukhin via Tarantool-patches wrote: > Hello, > > On 04 авг 11:26, imeevma@tarantool.org wrote: >> After this patch, bitwise operations will only accept UNSIGNED and >> positive INTEGER values as operands. The result of the bitwise operand >> will be UNSIGNED. >> >> Part of #4470 >> Closes #5364 >> --- >> https://github.com/tarantool/tarantool/issues/5364 >> https://github.com/tarantool/tarantool/tree/imeevma/gh-5364-fix-bitwise-operations > > I've checked your patch into 2.7, 2.8 and master. > > -- > Regards, Kirill Yukhin >