From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name
Date: Thu, 12 Jul 2018 11:54:49 +0300 [thread overview]
Message-ID: <c067d812-a5bb-ae89-012b-887d21ba5383@tarantool.org> (raw)
In-Reply-To: <1741e4e16438af3e3cb88ecd84a64faf711ad661.1531376946.git.kshcherbatov@tarantool.org>
Hello. Thanks for the patch!
I know, that removal of assertion always 'fixes' it, but please,
either fix it without removal (and for me it is not obvious why it
should be removed), or explain, why it is invalid.
On 12/07/2018 09:30, Kirill Shcherbatov wrote:
> Close #3522.
> ---
> https://github.com/tarantool/tarantool/compare/kshch/gh-3522-invalid-primary-key-column-name
> https://github.com/tarantool/tarantool/issues/3522
>
> src/box/sql/build.c | 1 -
> test/sql/gh-2929-primary-key.result | 7 +++++++
> test/sql/gh-2929-primary-key.test.lua | 5 +++++
> 3 files changed, 12 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2018-07-12 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 6:30 [tarantool-patches] " Kirill Shcherbatov
2018-07-12 8:54 ` Vladislav Shpilevoy [this message]
2018-07-12 10:03 ` [tarantool-patches] " Kirill Shcherbatov
2018-07-12 10:28 ` Vladislav Shpilevoy
2018-07-13 6:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c067d812-a5bb-ae89-012b-887d21ba5383@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox