Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] test: replication/wal_rw_stress fix wait_cond
Date: Tue, 14 Jul 2020 13:42:43 +0300	[thread overview]
Message-ID: <c0344914698895a9ef4172ee4e9a75ce563a2693.1594723276.git.avtikhon@tarantool.org> (raw)

Found that on heavy loaded hosts the test tries to check replication
downstream status when downstream structure is not ready and it fails
with the error:

[017] --- replication/wal_rw_stress.result	Thu Jul  9 17:04:16 2020
[017] +++ replication/wal_rw_stress.reject	Fri May  8 08:25:15 2020
[017] @@ -75,7 +75,8 @@
[017]      return box.info.replication[1].downstream.status ~= 'stopped' \
[017]  end) or box.info
[017]  ---
[017] -- true
[017] +- error: '[string "return test_run:wait_cond(function()         ..."]:1: attempt to
[017] +    index field ''downstream'' (a nil value)'
[017]  ...
[017]  test_run:cmd("switch default")
[017]  ---
[017]

So the wait condition should start from the check of the downstream
structure availability.

Follows up #4977
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4977-test-replication-wal_rw_stress
Issue: https://github.com/tarantool/tarantool/issues/4977

 test/replication/wal_rw_stress.result   | 6 ++++--
 test/replication/wal_rw_stress.test.lua | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/test/replication/wal_rw_stress.result b/test/replication/wal_rw_stress.result
index 50cfb08c7..41f307fc2 100644
--- a/test/replication/wal_rw_stress.result
+++ b/test/replication/wal_rw_stress.result
@@ -71,8 +71,10 @@ test_run:cmd("switch replica")
 box.cfg{replication = replication}
 ---
 ...
-test_run:wait_cond(function()                                     \
-    return box.info.replication[1].downstream.status ~= 'stopped' \
+test_run:wait_cond(function()                    \
+    local r = box.info.replication[1]            \
+    return (r ~= nil and r.downstream ~= nil and \
+            r.downstream.status ~= 'stopped')    \
 end) or box.info
 ---
 - true
diff --git a/test/replication/wal_rw_stress.test.lua b/test/replication/wal_rw_stress.test.lua
index e9b948518..96df2d6bf 100644
--- a/test/replication/wal_rw_stress.test.lua
+++ b/test/replication/wal_rw_stress.test.lua
@@ -38,8 +38,10 @@ test_run:cmd("setopt delimiter ''");
 -- are running in different threads, there shouldn't be any rw errors.
 test_run:cmd("switch replica")
 box.cfg{replication = replication}
-test_run:wait_cond(function()                                     \
-    return box.info.replication[1].downstream.status ~= 'stopped' \
+test_run:wait_cond(function()                    \
+    local r = box.info.replication[1]            \
+    return (r ~= nil and r.downstream ~= nil and \
+            r.downstream.status ~= 'stopped')    \
 end) or box.info
 test_run:cmd("switch default")
 
-- 
2.17.1

             reply	other threads:[~2020-07-14 10:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 10:42 Alexander V. Tikhonov [this message]
2020-07-14 11:24 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0344914698895a9ef4172ee4e9a75ce563a2693.1594723276.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] test: replication/wal_rw_stress fix wait_cond' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox