From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Georgy Kirichenko <georgy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/6] Synchronous replication preparation
Date: Sat, 23 Nov 2019 14:45:42 +0100 [thread overview]
Message-ID: <bfdce303-a38b-35d0-a2b7-1e2a2f56ea0e@tarantool.org> (raw)
In-Reply-To: <cover.1574178520.git.georgy@tarantool.org>
Hi!
You have 9 commits on top of this branch. What
should I review? Please, drop the commits
not related to this patchset from the branch.
Look at CI, it is broken:
https://travis-ci.org/tarantool/tarantool/builds/614719290?utm_source=github_status&utm_medium=notification
box-py/iproto.test.py does not pass.
> Georgy Kirichenko (6):
> recovery: do not throw an error
> coio: do not htrow an exception
> xstream: get rid of an exception
> vinyl: do not insert vy_tx twice into writers list
> box: improve recovery journal
> recovery: follow transaction boundaries while recovery or join
>
> src/box/applier.cc | 140 ++++++++--------
> src/box/box.cc | 119 ++++++++++----
> src/box/recovery.cc | 87 ++++++----
> src/box/recovery.h | 14 +-
> src/box/relay.cc | 47 +++---
> src/box/vy_tx.c | 2 +-
> src/box/xrow_io.cc | 59 +++----
> src/box/xrow_io.h | 11 +-
> src/box/xstream.cc | 7 +-
> src/box/xstream.h | 2 +-
> src/lib/core/coio.cc | 212 +++++++++++++------------
> src/lib/core/coio.h | 13 +-
> src/lib/core/coio_buf.h | 8 +
> test/xlog-py/big_lsn.result | 4 +
> test/xlog-py/big_lsn.test.py | 13 +-
> test/xlog-py/dup_key.result | 8 +
> test/xlog-py/dup_key.test.py | 7 +
> test/xlog/panic_on_broken_lsn.result | 9 +-
> test/xlog/panic_on_broken_lsn.test.lua | 7 +-
> 19 files changed, 449 insertions(+), 320 deletions(-)
>
prev parent reply other threads:[~2019-11-23 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 16:04 Georgy Kirichenko
2019-11-19 16:04 ` [Tarantool-patches] [PATCH 1/6] recovery: do not throw an error Georgy Kirichenko
2019-11-23 13:45 ` Vladislav Shpilevoy
2019-11-19 16:04 ` [Tarantool-patches] [PATCH 2/6] coio: do not htrow an exception Georgy Kirichenko
2019-11-23 13:45 ` Vladislav Shpilevoy
2019-11-19 16:04 ` [Tarantool-patches] [PATCH 3/6] xstream: get rid of " Georgy Kirichenko
2019-11-23 13:45 ` Vladislav Shpilevoy
2019-11-19 16:04 ` [Tarantool-patches] [PATCH 4/6] vinyl: do not insert vy_tx twice into writers list Georgy Kirichenko
2019-11-19 16:04 ` [Tarantool-patches] [PATCH 5/6] box: improve recovery journal Georgy Kirichenko
2019-11-23 13:46 ` Vladislav Shpilevoy
2019-11-19 16:04 ` [Tarantool-patches] [PATCH 6/6] recovery: follow transaction boundaries while recovery or join Georgy Kirichenko
2019-11-23 13:46 ` Vladislav Shpilevoy
2019-11-20 17:15 ` [Tarantool-patches] [PATCH 0/6] Synchronous replication preparation Konstantin Osipov
2019-11-23 13:45 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfdce303-a38b-35d0-a2b7-1e2a2f56ea0e@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/6] Synchronous replication preparation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox