From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Roman Khabibov <roman.habibov1@yandex.ru>
Subject: [tarantool-patches] Re: [PATCH] box: add a method to check if transaction is open
Date: Mon, 10 Sep 2018 09:21:43 +0300 [thread overview]
Message-ID: <bf5209a6-b5a3-aa49-3306-b61a1fabde0a@tarantool.org> (raw)
In-Reply-To: <1536282019-17978-1-git-send-email-roman.habibov1@yandex.ru>
Hi! Thank you for a patch.
> +bool
> +box_is_in_txn()
> +{
> + return box_txn();
> +}
1. Your function box_is_in_txn is a copy of box_txn routine. There is not reason to introduce it.
Moreover, box_txn is already exported as public API.
> +- - true
> +...
> +-- close transaction
> +box.commit();
2. Check box.is_in_txn(); here please.
> +-- gh-3518 no active transaction - false
3. Use tarantool codestyle for comments; at first, you need ticket description
--
-- gh-3518: Check if transaction opened.
--
> +box.is_in_txn();
> +-- start transaction
4. With a capital letter and with a dot at the end, please. Same for other comments.
next prev parent reply other threads:[~2018-09-10 6:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 1:00 [tarantool-patches] " Roman Khabibov
2018-09-10 6:21 ` Kirill Shcherbatov [this message]
2018-09-11 0:23 ` [tarantool-patches] " roman.habibov1
2018-09-11 0:25 ` roman.habibov1
2018-09-11 11:51 ` Kirill Shcherbatov
2018-09-19 13:38 ` Alexander Turenko
2018-09-21 0:54 ` [tarantool-patches] Re: [PATCH 1/1] " roman.habibov1
2018-09-21 2:41 ` Alexander Turenko
2018-09-21 22:29 ` roman.habibov1
2018-09-22 1:00 ` Alexander Turenko
2018-09-23 10:11 ` Vladislav Shpilevoy
2018-09-21 0:54 ` [tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature roman.habibov1
2018-09-21 2:53 ` Alexander Turenko
2018-09-21 22:25 ` roman.habibov1
2018-09-24 8:38 ` [tarantool-patches] Re: [PATCH] box: add a method to check if transaction is open Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5209a6-b5a3-aa49-3306-b61a1fabde0a@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=roman.habibov1@yandex.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] box: add a method to check if transaction is open' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox