From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org, tsafin@tarantool.org,
gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 2/2] uuid: fix unaligned memory access
Date: Thu, 21 May 2020 11:28:47 +0300 [thread overview]
Message-ID: <bf2205e5-748a-db81-b806-da1c94825dd3@tarantool.org> (raw)
In-Reply-To: <7cebd705-c3b9-a7b5-a244-2383da5520e9@tarantool.org>
The first commit lgtm too.
Sorry, I was meant to approve it one I checked it about a week ago
and examined the performance too.
I found out that on some platforms (at least on Xeon Gold) you
solution for bit_set is even faster.
On 5/21/20 12:38 AM, Vladislav Shpilevoy wrote:
> Only the second commit? Did you look at the first commit, for lib/bit?
>
> On 20/05/2020 10:18, Aleksandr Lyapunov wrote:
>> Thanks for the changes! Perfect with uuid_nil, lgtm.
next prev parent reply other threads:[~2020-05-21 8:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 23:03 [Tarantool-patches] [PATCH 0/2] Sanitize uuid and bit alignment Vladislav Shpilevoy
2020-05-15 23:03 ` [Tarantool-patches] [PATCH 1/2] bit: fix unaligned memory access and UB bit shift Vladislav Shpilevoy
2020-05-21 14:37 ` Timur Safin
2020-05-15 23:03 ` [Tarantool-patches] [PATCH 2/2] uuid: fix unaligned memory access Vladislav Shpilevoy
2020-05-18 12:55 ` Aleksandr Lyapunov
2020-05-18 21:17 ` Vladislav Shpilevoy
2020-05-19 7:28 ` Aleksandr Lyapunov
2020-05-19 8:34 ` Timur Safin
2020-05-19 21:24 ` Vladislav Shpilevoy
2020-05-20 8:18 ` Aleksandr Lyapunov
2020-05-20 21:38 ` Vladislav Shpilevoy
2020-05-21 8:28 ` Aleksandr Lyapunov [this message]
2020-05-21 14:37 ` Timur Safin
2020-05-21 19:33 ` [Tarantool-patches] [PATCH 0/2] Sanitize uuid and bit alignment Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf2205e5-748a-db81-b806-da1c94825dd3@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] uuid: fix unaligned memory access' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox