Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value
Date: Wed, 27 Jan 2021 17:44:09 +0300	[thread overview]
Message-ID: <be8b200b-2d7c-c2dc-876d-0f6ac039a820@tarantool.org> (raw)
In-Reply-To: <20210127143826.GL2174@grain>



27.01.2021 17:38, Cyrill Gorcunov пишет:
> On Wed, Jan 27, 2021 at 05:04:27PM +0300, Serge Petrenko wrote:
>>> diff --git a/src/box/relay.cc b/src/box/relay.cc
>>> index 9265a26b3..a486db23a 100644
>>> --- a/src/box/relay.cc
>>> +++ b/src/box/relay.cc
>>> @@ -571,7 +571,7 @@ relay_reader_f(va_list ap)
>>>    			/*
>>>    			 * Old versions may send not a timestamp but
>>>    			 * zeroified memory field. We can use +0 as
>>> -			 * as sign that there is nothing encoded.
>>> +			 * as a sign that there is nothing encoded.
>> Now there's double "as". Look at the previous line. =)
> Heh :) Thanks! Pushed an update.
> ---
> [cyrill@grain tarantool.git] git diff
> diff --git a/src/box/relay.cc b/src/box/relay.cc
> index a486db23a..859069a7b 100644
> --- a/src/box/relay.cc
> +++ b/src/box/relay.cc
> @@ -571,7 +571,7 @@ relay_reader_f(va_list ap)
>                          /*
>                           * Old versions may send not a timestamp but
>                           * zeroified memory field. We can use +0 as
> -                        * as a sign that there is nothing encoded.
> +                        * a sign that there is nothing encoded.
>                           */
>                          if (xrow.tm != 0)
>                                  relay->lag = ev_now(loop()) - xrow.tm;
>

LGTM.

-- 
Serge Petrenko


  reply	other threads:[~2021-01-27 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 17:17 [Tarantool-patches] [PATCH 0/3] box/info: report replication.X.downstream.lag Cyrill Gorcunov via Tarantool-patches
2021-01-21 17:17 ` [Tarantool-patches] [PATCH 1/3] xrow: encode timestamp into vclock message Cyrill Gorcunov via Tarantool-patches
2021-01-31 17:43   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-21 17:17 ` [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value Cyrill Gorcunov via Tarantool-patches
2021-01-27 11:56   ` Serge Petrenko via Tarantool-patches
2021-01-27 12:12     ` Cyrill Gorcunov via Tarantool-patches
2021-01-27 14:04       ` Serge Petrenko via Tarantool-patches
2021-01-27 14:38         ` Cyrill Gorcunov via Tarantool-patches
2021-01-27 14:44           ` Serge Petrenko via Tarantool-patches [this message]
2021-01-31 17:45   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-21 17:17 ` [Tarantool-patches] [PATCH 3/3] test: replication/status -- fetch downstream lag field Cyrill Gorcunov via Tarantool-patches
2021-01-31 17:46   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-21 17:17 ` Cyrill Gorcunov via Tarantool-patches
2021-01-21 17:23   ` Cyrill Gorcunov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be8b200b-2d7c-c2dc-876d-0f6ac039a820@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox