From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B593D70310; Wed, 27 Jan 2021 17:44:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B593D70310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611758651; bh=9c/4W/rwR1TudRfKcP6IwKZolzMahlS3DJNTv40DF8I=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BTt5Duw4WTxHEuPPEik9XDTuQeJinteZTo4qmMw4Z2dLYi+/jKYIHZGIlS54Sw+DW FG2yVydJeqeLOhCkx4EbnWAk37KVp3DmnqrNq8CMpF0jAHvAuli1RVctcmtyHuY1yl Oeuxl6/ES4CwHn1r8IqNvMFdCL30GSWdGA6awL4g= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B3CD970310 for ; Wed, 27 Jan 2021 17:44:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B3CD970310 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1l4m3F-0007kG-Vz; Wed, 27 Jan 2021 17:44:10 +0300 To: Cyrill Gorcunov Cc: tml , Vladislav Shpilevoy References: <20210121171753.186891-1-gorcunov@gmail.com> <20210121171753.186891-3-gorcunov@gmail.com> <14c1c58c-0645-0262-e70d-3bf92aa88a49@tarantool.org> <20210127121259.GK2174@grain> <20210127143826.GL2174@grain> Message-ID: Date: Wed, 27 Jan 2021 17:44:09 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210127143826.GL2174@grain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92BC6D7A73B5E1EC959C1FBF906E5CB90956EF1D42741DB9200894C459B0CD1B93BF8C88B24842DA3B661E93329E9AD09F32B92990FA576CB46CE9711DA951506 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75C94F75ECF5F42A4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372046934AE20E33CF8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC34595333FDB4EB37E5A43B463135AE21B3DC5F3318CAC17E389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0E45F71884F0C27A38941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B69F5E362153655AB1A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCA96415FF9D2A38D33AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F79006377C1DF3794FA78393D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7C3DDF88F19B2F251A93EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B678E91752D3FEA906089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7028C9DFF55498CEFB0BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5EE4DE831CB200ED40AD58FA07A6F0982076E3746D376B8E9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34980A6B448CFD1B8A58B5E9F0FA79826DB99AE4580674092E06A54F12110FF5C39A3E31AA09A40A1A1D7E09C32AA3244C800FAE9C36FB26133791AECC4E30F78B8580396430872480FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5ZUBkD5pAd/9J0pxjeFP7g== X-Mailru-Sender: 583F1D7ACE8F49BDF28A51E06CB90EC12958EC03AF6F3A1F4A0D1E231993DE7BA474CA1968103881823C4E0A9438D55D74690CA6451351EDEC462FDC9CAD1E11B969B486931C0B990F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 27.01.2021 17:38, Cyrill Gorcunov пишет: > On Wed, Jan 27, 2021 at 05:04:27PM +0300, Serge Petrenko wrote: >>> diff --git a/src/box/relay.cc b/src/box/relay.cc >>> index 9265a26b3..a486db23a 100644 >>> --- a/src/box/relay.cc >>> +++ b/src/box/relay.cc >>> @@ -571,7 +571,7 @@ relay_reader_f(va_list ap) >>> /* >>> * Old versions may send not a timestamp but >>> * zeroified memory field. We can use +0 as >>> - * as sign that there is nothing encoded. >>> + * as a sign that there is nothing encoded. >> Now there's double "as". Look at the previous line. =) > Heh :) Thanks! Pushed an update. > --- > [cyrill@grain tarantool.git] git diff > diff --git a/src/box/relay.cc b/src/box/relay.cc > index a486db23a..859069a7b 100644 > --- a/src/box/relay.cc > +++ b/src/box/relay.cc > @@ -571,7 +571,7 @@ relay_reader_f(va_list ap) > /* > * Old versions may send not a timestamp but > * zeroified memory field. We can use +0 as > - * as a sign that there is nothing encoded. > + * a sign that there is nothing encoded. > */ > if (xrow.tm != 0) > relay->lag = ev_now(loop()) - xrow.tm; > LGTM. -- Serge Petrenko